rust: Drop dependency on memfd
#4597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An anonymous tmpfile is strictly better than memfd for a case like this, where we want to be able to page back to disk if needed for some reason. Prep for dropping a dependency on the `memfd` crate.
The immediate motivation here is to ideally get back to one version of `rustix` - we have just too many versions of `nix` and `rustix`. The slight additional ergonomics of the `memfd` crate aren't really worth it over using the already-safe rustix interface directly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
composepost: Use O_TMPFILE, not memfd
An anonymous tmpfile is strictly better than memfd for a case
like this, where we want to be able to page back to disk if needed
for some reason.
Prep for dropping a dependency on the
memfdcrate.rust: Drop dependency on
memfdThe immediate motivation here is to ideally get back to one version
of
rustix- we have just too many versions ofnixandrustix.The slight additional ergonomics of the
memfdcrate aren'treally worth it over using the already-safe rustix interface
directly.