Pin bootc to a git tag #4584
Merged
Pin bootc to a git tag #4584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right, another race |
|
Oh wait that's not a race:
|
|
Oh I see, I think what's going on is in our CI in Jenkins we override things to run as uid 0, which triggers this code: So...fun. It'd be good to drop the |
We had a problem in the previous release with having bootc float on a git commit because it ends up meaning "whatever happens to be on the developer's machine" when cutting a release, which is not OK from a reproducibility PoV. Dependabot I think can help us update this.
cgwalters
force-pushed
the
pin-bootc
branch
from
74561c0 to
c70c9cd
Compare
cgwalters
added a commit
to cgwalters/coreos-assembler
that referenced
this pull request
Sep 18, 2023
I want to reproduce the failure from coreos/rpm-ostree#4584 (comment) So I can verify the fix works here.
cgwalters
added a commit
to cgwalters/coreos-assembler
that referenced
this pull request
Sep 18, 2023
I want to reproduce the failure from coreos/rpm-ostree#4584 (comment) So I can verify the fix works here.
cgwalters
added a commit
to cgwalters/coreos-assembler
that referenced
this pull request
Sep 18, 2023
I want to reproduce the failure from coreos/rpm-ostree#4584 (comment) So I can verify the fix works here.
cgwalters
added a commit
to cgwalters/coreos-assembler
that referenced
this pull request
Sep 18, 2023
I want to reproduce the failure from coreos/rpm-ostree#4584 (comment) So I can verify the fix works here.
cgwalters
added a commit
to cgwalters/coreos-assembler
that referenced
this pull request
Sep 18, 2023
I want to reproduce the failure from coreos/rpm-ostree#4584 (comment) So I can verify the fix works here.
cgwalters
added a commit
to cgwalters/coreos-assembler
that referenced
this pull request
Sep 18, 2023
I want to reproduce the failure from coreos/rpm-ostree#4584 (comment) So I can verify the fix works here.
cgwalters
added a commit
to cgwalters/coreos-assembler
that referenced
this pull request
Sep 18, 2023
I want to reproduce the failure from coreos/rpm-ostree#4584 (comment) So I can verify the fix works here.
cgwalters
added a commit
to cgwalters/coreos-assembler
that referenced
this pull request
Sep 18, 2023
I want to reproduce the failure from coreos/rpm-ostree#4584 (comment) So I can verify the fix works here.
cgwalters
added a commit
to cgwalters/coreos-assembler
that referenced
this pull request
Sep 18, 2023
I want to reproduce the failure from coreos/rpm-ostree#4584 (comment) So I can verify the fix works here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had a problem in the previous release with having bootc float on a git commit because it ends up meaning "whatever happens to be on the developer's machine" when cutting a release, which is not OK from a reproducibility PoV.
Dependabot I think can help us update this.