-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
alternatives: update doc to use the usual alternatives
commands
#673
Conversation
ea7020f
to
d846fad
Compare
46da572
to
14a0c25
Compare
This looks good. In coordination with coreos/fedora-coreos-tracker#1818, I think we should refocus this page on the reverse of what we have for instructions right now, which is to say that we should give the instructions to "update" systems to the nft backend instead, as we'll be removing the legacy one. We can only do that for the manual part for now. |
Let's see how that works in a systemd unit as well to run this via Ignition. |
8d08485
to
416801a
Compare
416801a
to
aa569e2
Compare
your examples here set
also.. what does this output mean? I see |
I think it is because we add postprocess to make it manually default to
Both |
right. I'm just pointing out that our example should probably be changing it from what we already ship as default? Maybe there is another better example? |
The idea was to give as example the migration that we would want to have users do in coreos/fedora-coreos-tracker#1818 (moving legacy systems to the nft backend). But I agree that it does not work for the Butane config as we already do that. I don't think we should show the reverse however as we don't want users to go to the legacy backend as we ideally should remove it. Not sure if we actually have another "alternatives" command to use for the example. |
agree. Thanks for the clarification |
There is one
|
right, but there is only one option installed, so still probably not a good example? I say we just have the butane example show setting it to iptables-legacy and note that we don't recommend doing that, it's just an example. Then we can have the interactive example set iptables-nft (for those systems that are somehow still on legacy). |
Agree this is just an example to run alternatives using butane or manually command, then is this OK to merge? |
I would update the PR to set iptables legacy in the butane example. Other than that - LGTM. |
and, of course @travier may have a different opinion. |
How about adding a note to remind that if want to set iptables to legacy, just replace the target to |
I guess. It's just confusing to have an example that sets a value to what is already the default. i.e. if I was testing this documentation I'd have no way to verify it worked
I'd think it was a problem with the docs personally. |
d0006a2
to
ac0627a
Compare
Update doc: the butane example to configure the default iptables to |
looks pretty good to me - a few final comments. |
ac0627a
to
784b12a
Compare
See coreos/fedora-coreos-tracker#677 (comment)