overlay.d & tests: Add alternatives migration and test #3253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HuijingHei
reviewed
Nov 15, 2024
HuijingHei
reviewed
Nov 15, 2024
travier
force-pushed
the
testing-devel-alternatives-migration
branch
from
484d98b to
2ba6b2a
Compare
aaradhak
reviewed
Nov 15, 2024
travier
force-pushed
the
testing-devel-alternatives-migration
branch
from
2ba6b2a to
086b0fa
Compare
- Add an overlay with the migration logic for alternatives - Add a test for the migration script This should make sure that the system is setup properly and that the migration script will do the right thing on older systems. See: coreos/fedora-coreos-tracker#1818 See: coreos/fedora-coreos-tracker#677 See: https://docs.fedoraproject.org/en-US/fedora-coreos/alternatives/
travier
force-pushed
the
testing-devel-alternatives-migration
branch
from
086b0fa to
273dbde
Compare
travier
changed the title
|
I've now added the migration script to this PR and a test for it. Not fully tested yet. |
HuijingHei
reviewed
Nov 21, 2024
|
|
||
| main() { | ||
| # Should never happen as systemd checks this, but just in case | ||
| if [[ ! -d "/var/lib/alternatives" ]]; then |
There was a problem hiding this comment.
On silverblue, check /var/lib/alternatives is broken link, should we care about this?
$ ls /var/lib/alternatives -al
lrwxrwxrwx. 1 root root 26 Oct 16 07:16 /var/lib/alternatives -> ../../usr/lib/alternatives
There was a problem hiding this comment.
Indeed, if we want to have a single migration script for all variants then we should take this one into account.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
overlay.d: Add empty statoverride config files
overlay.d & tests: Add alternatives migration and test
This should make sure that the system is setup properly and that the
migration script will do the right thing on older systems.
See: coreos/fedora-coreos-tracker#1818
See: coreos/fedora-coreos-tracker#677
See: https://docs.fedoraproject.org/en-US/fedora-coreos/alternatives/