Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

packit.yaml: add c9s #1446

Merged
merged 1 commit into from
Jul 22, 2024
Merged

packit.yaml: add c9s #1446

merged 1 commit into from
Jul 22, 2024

Conversation

HuijingHei
Copy link
Member

No description provided.

@packit-as-a-service Packit-as-a-Service
Copy link

Failed to load packit config file:

Cannot parse package config. ValidationError({'jobs': {0: {'coreos-installer-fedora': ["'specfile_path' is not specified or no specfile was found in the repo"]}, 1: {'coreos-installer-fedora': ["'specfile_path' is not specified or no specfile was found in the repo"], 'coreos-installer-centos': ["'specfile_path' is not specified or no specfile was found in the repo"]}, 2: {'coreos-installer-fedora': ["'specfile_path' is not specified or no specfile was found in the repo"], 'coreos-installer-centos': ["'specfile_path' is not specified or no specfile was found in the repo"]}, 3: {'coreos-installer-centos': ["'specfile_path' is not specified or no specfile was found in the repo"]}}})

For more info, please check out the documentation or contact the Packit team. You can also use our CLI command validate-config or our pre-commit hooks for validation of the configuration.

2 similar comments
@packit-as-a-service Packit-as-a-Service
Copy link

Failed to load packit config file:

Cannot parse package config. ValidationError({'jobs': {0: {'coreos-installer-fedora': ["'specfile_path' is not specified or no specfile was found in the repo"]}, 1: {'coreos-installer-fedora': ["'specfile_path' is not specified or no specfile was found in the repo"], 'coreos-installer-centos': ["'specfile_path' is not specified or no specfile was found in the repo"]}, 2: {'coreos-installer-fedora': ["'specfile_path' is not specified or no specfile was found in the repo"], 'coreos-installer-centos': ["'specfile_path' is not specified or no specfile was found in the repo"]}, 3: {'coreos-installer-centos': ["'specfile_path' is not specified or no specfile was found in the repo"]}}})

For more info, please check out the documentation or contact the Packit team. You can also use our CLI command validate-config or our pre-commit hooks for validation of the configuration.

@packit-as-a-service Packit-as-a-Service
Copy link

Failed to load packit config file:

Cannot parse package config. ValidationError({'jobs': {0: {'coreos-installer-fedora': ["'specfile_path' is not specified or no specfile was found in the repo"]}, 1: {'coreos-installer-fedora': ["'specfile_path' is not specified or no specfile was found in the repo"], 'coreos-installer-centos': ["'specfile_path' is not specified or no specfile was found in the repo"]}, 2: {'coreos-installer-fedora': ["'specfile_path' is not specified or no specfile was found in the repo"], 'coreos-installer-centos': ["'specfile_path' is not specified or no specfile was found in the repo"]}, 3: {'coreos-installer-centos': ["'specfile_path' is not specified or no specfile was found in the repo"]}}})

For more info, please check out the documentation or contact the Packit team. You can also use our CLI command validate-config or our pre-commit hooks for validation of the configuration.

@HuijingHei HuijingHei force-pushed the packit-c9s branch 2 times, most recently from 5d5231a to 78d48a1 Compare April 10, 2024 12:08
@HuijingHei HuijingHei requested a review from prestist April 10, 2024 12:08
jlebon
jlebon approved these changes Apr 12, 2024
View reviewed changes
Copy link
Member

@jlebon jlebon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

.packit.yaml Outdated Show resolved Hide resolved
.packit.yaml
trigger: release
packages: [coreos-installer-centos]
dist_git_branches:
- c9s
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might as well add c10s now. Or is Packit integration not yet done for that yet?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

err, at least according to docs https://packit.dev/docs/configuration/upstream/propose_downstream#syncing-the-release-to-centos-stream c8s and c9s are it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this mean it will create PR and merge automatically, is it necessary to add comment like resolve #<bug> ?

.packit.yaml
changelog-entry:
- bash -c 'echo "- New upstream release"'
coreos-installer-centos:
pkg_tool: centpkg
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kinda surprised Packit needs to be told this.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol meeee too.

prestist
prestist previously approved these changes Apr 15, 2024
View reviewed changes
Copy link
Contributor

@prestist prestist left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, thank you @HuijingHei !

Edit: almost, looks like you need to remove an extra specfile_path field

@prestist prestist dismissed their stale review April 15, 2024 21:03

almost, looks like you need to remove an extra specfile_path field

@prestist
Copy link
Contributor

prestist commented Jul 22, 2024 •
edited
Loading

Switched us over to fedora-rawhide from prior discussion, Additionally rebased to get this merged.

Hind sight, I should have rebased, and pushed first. Sorry about that.

@HuijingHei @prestist
packit.yaml: add c9s
d0eaa43 
Additionally set propose-downstream to fedora-rawhide
until packit/packit#1724 is resolved.

Co-authored-by: Huijing Hei <[email protected]>
@prestist prestist enabled auto-merge July 22, 2024 17:35
@prestist prestist mentioned this pull request Jul 22, 2024
Closed
59 tasks
@prestist prestist merged commit bf15feb into coreos:main Jul 22, 2024
14 checks passed
@HuijingHei HuijingHei deleted the packit-c9s branch July 26, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prestist prestist prestist left review comments

@jlebon jlebon jlebon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HuijingHei @prestist @jlebon