s390x: add zVM Secure IPL support #1338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikita-dubrovskii
force-pushed
the
zvm_secure_ipl
branch
4 times, most recently
from
5567618 to
2739de2
Compare
jlebon
reviewed
Nov 17, 2023
nikita-dubrovskii
changed the title
nikita-dubrovskii
force-pushed
the
zvm_secure_ipl
branch
2 times, most recently
from
838be73 to
f9e2bf6
Compare
jlebon
reviewed
Nov 20, 2023
nikita-dubrovskii
force-pushed
the
zvm_secure_ipl
branch
2 times, most recently
from
ca33d36 to
7fc8eeb
Compare
jlebon
reviewed
Nov 23, 2023
nikita-dubrovskii
force-pushed
the
zvm_secure_ipl
branch
4 times, most recently
from
0238bbc to
38d3ca0
Compare
jlebon
reviewed
Nov 30, 2023
nikita-dubrovskii
force-pushed
the
zvm_secure_ipl
branch
2 times, most recently
from
7e2ed26 to
dc4b19d
Compare
jlebon
approved these changes
Dec 4, 2023
nikita-dubrovskii
force-pushed
the
zvm_secure_ipl
branch
from
dc4b19d to
ec2bd25
Compare
jlebon
approved these changes
Dec 6, 2023
cgwalters
reviewed
Dec 6, 2023
Comment on lines
+43
to
+52
| fn parse_lszdev_eckd(line: &str) -> Result<Loaddev> { | ||
| // ECKD ID looks like: 0.0.5223, we need only last part of it (5223) | ||
| lazy_static! { | ||
| static ref REGEX: Regex = Regex::new(r#"[[:digit:]].[[:digit:]].([[:xdigit:]]+)"#).unwrap(); | ||
| } | ||
| if let Some(cap) = REGEX.captures_iter(line).next() { | ||
| return Ok(Loaddev::Eckd(cap[1].to_string())); | ||
| } | ||
| bail!("bad ECKD id: {}", line); | ||
| } |
There was a problem hiding this comment.
This is obviously totally fine, but just noting I think it's a one-liner to parse this without regexps:
line.split('.').nth(2).ok_or_else(|| anyhow!("Bad EKCD")).map(|s| Loaddev::Eckd(s.to_string()))
or so. (Though validation is looser)
There was a problem hiding this comment.
Yep, the reason to use regex here was to validate format of ID, which probably not that necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements proposal from: coreos/enhancements#10