cmdlib.sh: drop runvm_with_cache_snapshot() #3970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/hold :) - I think there are various CI configurations that we need to fixup before we can merge this. |
Hmm, are you thinking about CIs that currently build things in parallel and rely on this? AFAICT it's only in cosa that we do this. Everywhere else where we e.g. build metal and metal4k, we do it serially already. So... I think we just need to adjust: coreos-assembler/.cci.jenkinsfile Line 33 in db738cd ? |
This was used as part of the legacy building of extensions and should have been dropped alongside that code in 48414b3.
We can do this all with OSBuild now so let's not run parallel processes here. This will enable us to drop the cache snapshot bits since we won't have two processes trying to use the cache qcow at the same time.
In the case where we were running multiple parallel tasks in the pipeline that were running VMs and accessing the cache qcow we needed this, but with [1] we are now consolidating all OSBuild pipeline tasks into single non-parallel invocations. [1] coreos/fedora-coreos-pipeline#1055
This is now no longer used. runvm_with_cache_snapshot was used by runvm-osbuild previously but it's not needed any longer and cosa supermin-run --snapshot was used by build-podman-os job in the pipeline, but that isn't being used either so we can drop it.
dustymabe
force-pushed
the
dusty-drop-snapshot
branch
from
b62a9c1 to
d5a05c0
Compare
Done |
|
/unhold |
dustymabe
added a commit
to coreosbot-releng/fedora-coreos-config
that referenced
this pull request
Nov 24, 2024
Since we dropped runvm_with_cache_snapshot this now fails. Let's make a similar change here as what we did in coreos/coreos-assembler#3970
dustymabe
added a commit
to coreos/fedora-coreos-config
that referenced
this pull request
Nov 24, 2024
Since we dropped runvm_with_cache_snapshot this now fails. Let's make a similar change here as what we did in coreos/coreos-assembler#3970
At least one other place: coreos/fedora-coreos-config@f945860 |
aaradhak
pushed a commit
to aaradhak/fedora-coreos-config
that referenced
this pull request
Dec 4, 2024
Since we dropped runvm_with_cache_snapshot this now fails. Let's make a similar change here as what we did in coreos/coreos-assembler#3970
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.