Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmdlib.sh: only chown compose.json if it exists #3969

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

jlebon
Copy link
Member

@jlebon jlebon commented Nov 22, 2024

It only gets actually written in cosa build, so we need to handle the cosa fetch case where this path is also taken.

Fixes 40a2027 ("cmdlib: also chown back compose.json in privileged path").

It only gets actually written in `cosa build`, so we need to handle the
`cosa fetch` case where this path is also taken.

Fixes 40a2027 ("cmdlib: also chown back `compose.json` in privileged
path").
Copy link
Member

@dustymabe dustymabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dustymabe dustymabe enabled auto-merge (rebase) November 22, 2024 13:52
@jlebon
Copy link
Member Author

jlebon commented Nov 22, 2024

CI failure is unrelated. It went well past where this code is used. Let's just get it in to unbreak the pipeline.

@jlebon jlebon disabled auto-merge November 22, 2024 16:03
@jlebon jlebon merged commit db738cd into coreos:main Nov 22, 2024
4 of 5 checks passed
@jlebon jlebon deleted the pr/fetch-only branch November 22, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants