-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[rhcos-4.17] mantle/platform/aws: handle missing details fields #3965
[rhcos-4.17] mantle/platform/aws: handle missing details fields #3965
Conversation
Possibly something changed on the AWS side, but we're seeing what looks like `SnapshotTaskDetail` structs coming back with some of the fields empty. Gracefully handle this case.
Hi @openshift-cherrypick-robot. Thanks for your PR. I'm waiting for a coreos member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
CI keeps failing in the kola stage:
|
It doesn't work properly against these rhcos- branches anyway. Let's just limit the testing to building the container and running check and unittest tests.
CI is still failing even with the |
Hmm yeah, I think the issue here is that openshift-cherrypick-robot is not trusted by CoreOS CI so the latter is refusing to use the modified version. The bot account would need to be part of the coreos org. Anyway, we can force this in for now. Future PRs against this branch will have the change. |
This is an automated cherry-pick of #3959
/assign marmijo