Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rhcos-4.17] mantle/platform/aws: handle missing details fields #3965

Conversation

openshift-cherrypick-robot

This is an automated cherry-pick of #3959

/assign marmijo

Possibly something changed on the AWS side, but we're seeing what looks
like `SnapshotTaskDetail` structs coming back with some of the fields
empty. Gracefully handle this case.
Copy link

openshift-ci bot commented Nov 21, 2024

Hi @openshift-cherrypick-robot. Thanks for your PR.

I'm waiting for a coreos member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@marmijo
Copy link
Member

marmijo commented Nov 21, 2024

/ok-to-test

@marmijo
Copy link
Member

marmijo commented Nov 21, 2024

CI keeps failing in the kola stage:

[2024-11-21T23:05:30.779Z] Error: Unknown distribution: null
[2024-11-21T23:05:30.779Z] 2024-11-21T23:05:30Z cli: Unknown distribution: null

It doesn't work properly against these rhcos- branches anyway. Let's
just limit the testing to building the container and running check
and unittest tests.
@marmijo
Copy link
Member

marmijo commented Nov 22, 2024

CI is still failing even with the .cci.Jenkinsfile commit. Maybe I needed to add the commit as a separate PR? Can I get some assistance. I think we can safely merge this and #3964.

@jlebon
Copy link
Member

jlebon commented Nov 22, 2024

Hmm yeah, I think the issue here is that openshift-cherrypick-robot is not trusted by CoreOS CI so the latter is refusing to use the modified version. The bot account would need to be part of the coreos org. Anyway, we can force this in for now. Future PRs against this branch will have the change.

@jlebon jlebon merged commit 86f8ce4 into coreos:rhcos-4.17 Nov 22, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants