cosalib/container_manifest.py: cleanup manifest before create/push #3952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This was partially exposed because of coreos/fedora-coreos-pipeline#1047 where we're now using the persistent builders for this task. |
aaradhak
reviewed
Nov 19, 2024
| @@ -19,6 +19,22 @@ def create_local_container_manifest(repo, tag, images) -> dict: | |||
| capture_output=True).stdout | |||
| return json.loads(manifest_info) | |||
|
|
|||
There was a problem hiding this comment.
Need an extra line here? CI test fails as two blank lines are required before every function.
aaradhak
reviewed
Nov 19, 2024
| if cp.stderr: | ||
| print(f" STDERR: {cp.stderr.decode()}") | ||
| raise Exception("Error encountered when checking if manifest exists") | ||
| return cp.returncode == 0 | ||
|
|
If a manifest previously exists then let's try to clean it up before continuing. We saw this in the pipeline where one run failed in the middle and then a later run failed because the manifest existed: ``` 2024-11-19 14:29:26,184 INFO - Running command: ['podman', 'manifest', 'create', 'quay.io/coreos-assembler/coreos-assembler:main'] Error: creating manifest: image name "quay.io/coreos-assembler/coreos-assembler:main" is already associated with image "ffbb463bfb0e3bb0fb4c42856d2dca0ff985d1dd5d7b34f1b3ae0277287ad83d": that name is already in use ```
dustymabe
force-pushed
the
dusty-push-container-manifest
branch
from
7a53b49 to
9639525
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a manifest previously exists then let's try to clean it up before continuing. We saw this in the pipeline where one run failed in the middle and then a later run failed because the manifest existed: