cmd-generate-release-meta: allow missing base-oscontainer
#3949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/lgtm |
dustymabe
reviewed
Nov 18, 2024
Commit 21802b6 ("cmd-generate-release-meta: inject `oci-image` key in release metadata") broke the OKD pipeline which builds the OCI image, but doesn't push it using cosa. Down the line, this should resolve itself by having OKD and OCP's node image being built the same way as layered images. But for now let's relax the check here and just inject the OCI image information if it's available.
jlebon
force-pushed
the
pr/dont-assert-base-oscontainer
branch
from
568d85f to
1b395ce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 21802b6 ("cmd-generate-release-meta: inject
oci-imagekey in release metadata") broke the OKD pipeline which builds the OCI image, but doesn't push it using cosa.Down the line, this should resolve itself by having OKD and OCP's node image being built the same way as layered images.
But for now let's relax the check here and just inject the OCI image information if it's available.