cmd-cloud-prune: merge container-prune into cloud-prune #3940
Conversation
gursewak1997
force-pushed
the
merge-containers-gc
branch
from
b6935e3 to
478cf87
Compare
gursewak1997
force-pushed
the
merge-containers-gc
branch
from
478cf87 to
5b2eac5
Compare
gursewak1997
force-pushed
the
merge-containers-gc
branch
from
5b2eac5 to
954ccb3
Compare
| subprocess.check_output(skopeo_args, stderr=subprocess.STDOUT) | ||
| print("Image deleted successfully.") | ||
| except subprocess.CalledProcessError as e: | ||
| raise Exception("An error occurred during deletion:", e.output.decode("utf-8")) |
There was a problem hiding this comment.
I wonder if there is a way for us to gracefully exit here i.e. there was a lot of work done before this that would be nice to save (via updating builds.json). But maybe that's not too important.
There was a problem hiding this comment.
Agreed, and this applies to other actions as well. Initially, we discussed this and concluded that updating the builds.json file in every run didn’t make much sense. The focus was to minimize updates to the file with any kind of failure.
Ideally, subsequent runs shouldn’t take more than a few minutes, apart from the first iteration for each stream. Hence, it didn’t seem like a critical concern.
There was a problem hiding this comment.
maybe we should consider renaming this coreos-prune or something since it's doing it all now.
Let's only do that in a separate PR (or maybe one final commit once we're at the end of code review).
There was a problem hiding this comment.
Will open another PR for this once this gets merged in.
gursewak1997
force-pushed
the
merge-containers-gc
branch
from
954ccb3 to
8ac5e2c
Compare
gursewak1997
force-pushed
the
merge-containers-gc
branch
from
8ac5e2c to
9417b02
Compare
Merged the code of the container gc into the cloud one, and update builds.json. Go through the tags in base-oscontainer data in meta.json and prune every tag except the stream-name itself which are moving tags.
gursewak1997
force-pushed
the
merge-containers-gc
branch
from
9417b02 to
a520781
Compare
Merged the code of the container gc into the cloud one, and updated
builds.json. Please go through the tags in base-oscontainer data in meta.json and prune every tag except the stream name, which are moving tags.