Skip to content

Commit

Permalink
kola/core.go: remove fcos.internet test
Browse files Browse the repository at this point in the history
This test has been denylisted in FCOS for a long time due to rate
limiting issues with the busybox container. The functionality of the
test is covered by other FCOS tests so it can be removed.
Also remove some older, obsolete functions that were probably a part
of this test in the past.

see: https://issues.redhat.com/browse/COS-2094
  • Loading branch information
marmijo authored and dustymabe committed Nov 14, 2024
1 parent 6f86f45 commit f5e20b9
Showing 1 changed file with 0 additions and 41 deletions.
41 changes: 0 additions & 41 deletions mantle/kola/tests/coretest/core.go
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ import (
"github.com/coreos/coreos-assembler/mantle/kola/register"
"github.com/coreos/coreos-assembler/mantle/platform"
"github.com/coreos/coreos-assembler/mantle/platform/machine/qemu"
"github.com/coreos/coreos-assembler/mantle/util"
)

const (
Expand Down Expand Up @@ -91,21 +90,6 @@ func init() {
// only work on x86_64 and aarch64.
Architectures: []string{"x86_64", "aarch64"},
})
// TODO: Enable DockerPing/DockerEcho once fixed
// TODO: Only enable PodmanPing on non qemu. Needs:
// https://github.com/coreos/mantle/issues/1132
register.RegisterTest(&register.Test{
Name: "fcos.internet",
Description: "Verify that podman echo and get head work.",
Run: InternetTests,
ClusterSize: 1,
Tags: []string{kola.NeedsInternetTag},
NativeFuncs: map[string]register.NativeFuncWrap{
"PodmanEcho": register.CreateNativeFuncWrap(TestPodmanEcho),
"PodmanWgetHead": register.CreateNativeFuncWrap(TestPodmanWgetHead),
},
Distros: []string{"fcos"},
})
register.RegisterTest(&register.Test{
Name: "rootfs.uuid",
Description: "Verify that the root disk's GUID was set to a random one on first boot.",
Expand Down Expand Up @@ -179,31 +163,6 @@ func TestPortSsh() error {
return nil
}

func TestDockerEcho() error {
//t.Parallel()
return util.RunCmdTimeout(DockerTimeout, "docker", "run", "busybox", "echo")
}

func TestDockerPing() error {
//t.Parallel()
return util.RunCmdTimeout(DockerTimeout, "docker", "run", "busybox", "ping", "-c4", "coreos.com")
}

func TestPodmanEcho() error {
//t.Parallel()
return util.RunCmdTimeout(DockerTimeout, "podman", "run", "busybox", "echo")
}

func TestPodmanPing() error {
//t.Parallel()
return util.RunCmdTimeout(DockerTimeout, "podman", "run", "busybox", "ping", "-c4", "coreos.com")
}

func TestPodmanWgetHead() error {
//t.Parallel()
return util.RunCmdTimeout(DockerTimeout, "podman", "run", "busybox", "wget", "--spider", "http://fedoraproject.org/static/hotspot.txt")
}

// This execs gdbus, because we need to change uses to test perms.
func TestDbusPerms() error {
c := exec.Command(
Expand Down

0 comments on commit f5e20b9

Please sign in to comment.