Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stablize fcos v1_6, base v0_6, and bump all other exp to latest #566

Merged
merged 13 commits into from
Nov 27, 2024

Conversation

prestist
Copy link
Collaborator

@prestist prestist changed the title Stablize fcos v1_6, basev0_6, and bump all other exp to latest Stablize fcos v1_6, base v0_6, and bump all other exp to latest Nov 26, 2024
@prestist prestist force-pushed the stablize-fcos-base-ocp branch from 326623b to 237e6a5 Compare November 26, 2024 20:45
@prestist prestist requested a review from travier November 26, 2024 20:53
Copy link
Member

@travier travier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks. Only a few minor nits for the notes/docs.

docs/release-notes.md Outdated Show resolved Hide resolved
docs/release-notes.md Outdated Show resolved Hide resolved
docs/upgrading-fcos.md Outdated Show resolved Hide resolved
docs/upgrading-fcos.md Outdated Show resolved Hide resolved
docs/upgrading-fcos.md Outdated Show resolved Hide resolved
docs/upgrading-fcos.md Outdated Show resolved Hide resolved
@travier
Copy link
Member

travier commented Nov 27, 2024

Great splitting of commits which made reviewing this a breeze 👍🏻

@prestist prestist force-pushed the stablize-fcos-base-ocp branch from 237e6a5 to b8c1857 Compare November 27, 2024 15:19
@prestist
Copy link
Collaborator Author

prestist commented Nov 27, 2024

Sigh, sorry about the doc's it was the last step and just rushed it, should have been more particular.

I think its correct now. Thank you!

Sigh I applied recommended changes and it did some weeird (working through it) automation stubbed my toe.

Alright should be good now, sorry about noise.

@prestist prestist force-pushed the stablize-fcos-base-ocp branch 3 times, most recently from ae4c9a7 to cd63cc6 Compare November 27, 2024 15:24
@travier
Copy link
Member

travier commented Nov 27, 2024

Let's also mention the new boot_device layouts added as part of this PR #484 for s390x in the updates notes.

docs/upgrading-fcos.md Outdated Show resolved Hide resolved
@travier
Copy link
Member

travier commented Nov 27, 2024

This can also be a follow up PR as this one is already large.

@prestist prestist force-pushed the stablize-fcos-base-ocp branch 2 times, most recently from f89f887 to 3683471 Compare November 27, 2024 16:59
@prestist prestist force-pushed the stablize-fcos-base-ocp branch from c3b97a2 to 142bfeb Compare November 27, 2024 17:01
@travier travier merged commit 83ce1eb into coreos:main Nov 27, 2024
7 checks passed
travier added a commit to travier/butane that referenced this pull request Nov 27, 2024
The experimental specs are now using the 3.6.0-experimental ignition
spec.

Fixes: coreos#566
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants