fix: change display audit report and bugs

- fix payment pos invoice not deleted if null
- fix reversed credit account in breakfast

inn/inn_hotels/doctype/inn_room_charge_posting/inn_room_charge_posting.py

@@ -217,7 +217,7 @@ def post_individual_room_charges(parent_id, tobe_posted_list):
 				breakfast_commission.amount = float(int(channel.breakfast_cashback))
 				accumulated_amount += float(int(channel.breakfast_cashback))
 				breakfast_commission.credit_account = PROFIT_SHARING_ACCOUNT
-				breakfast_commission.debit_account = breakfast_charge_credit_account
+				breakfast_commission.debit_account = breakfast_charge_debit_account
 				breakfast_commission.remark = 'Commission ' + channel.name + ' : ' + item_doc.room_id + " - " + get_last_audit_date().strftime("%d-%m-%Y")
 				breakfast_commission.parent = item_doc.folio_id
 				breakfast_commission.parenttype = 'Inn Folio'

inn/inn_hotels/report/audit_report/audit_report.js

@@ -20,4 +20,12 @@ frappe.query_reports["Audit Report"] = {
 	"name_field": "account",
 	"parent_field": "parent_account",
 	"initial_depth": 1,
+	"formatter": function (value, row, column, data, default_formatter) {
+		value = default_formatter(value, row, column, data)
+
+		if (column.fieldname == "rsv") {
+			value = `<a href='/app/inn-reservation/${value}'>${value}</a>`
+		}
+		return value
+	}
 };

inn/inn_hotels/report/audit_report/audit_report.json

@@ -5,19 +5,11 @@
  "disabled": 0,
  "docstatus": 0,
  "doctype": "Report",
- "filters": [
-  {
-   "fieldname": "start_date",
-   "fieldtype": "Date",
-   "label": "Audit Date",
-   "mandatory": 1,
-   "wildcard_filter": 0
-  }
- ],
+ "filters": [],
  "idx": 0,
  "is_standard": "Yes",
  "letterhead": null,
- "modified": "2024-03-04 14:37:38.306455",
+ "modified": "2024-07-02 11:42:04.364467",
  "modified_by": "Administrator",
  "module": "Inn Hotels",
  "name": "Audit Report",

inn/overrides/erpnext/accounts/pos_invoice/pos_invoice.py

@@ -1,10 +1,5 @@
 import frappe
 
-def before_submit(doc, method=None):
-
-    for index, payment in enumerate(doc.payments):
-        if payment.amount == 0:
-            frappe.delete_doc_if_exists("Sales Invoice Payment", payment.name)
-            doc.payments.pop(index)
 
-
+def before_submit(doc, method=None):
+    doc.payments = [payment for payment in doc.payments if payment.amount != 0]