Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(icon-button): change import button desktop -> mobile #1511

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

denisx
Copy link
Contributor

@denisx denisx commented Dec 21, 2024

Опишите проблему

Замена универсального импорта кнопки на мобильную версию. Кнопка нужна только как функционал, а он между д/м одинаковый. Поэтому сплитить сам компонент icon-button на д/м (и все от него зависимые) не нужно

Внешний вид

Без изменений

https://core-ds.github.io/core-components/feat_ds_7758_35_cdbaa9e172a712deca7f8b2835383d33b9739997/?path=/story/iconbutton--icon-button

Copy link

changeset-bot bot commented Dec 21, 2024

🦋 Changeset detected

Latest commit: 6b1d2c3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 33 packages
Name Type
@alfalab/core-components-icon-button Patch
@alfalab/core-components-calendar Patch
@alfalab/core-components-date-range-input Patch
@alfalab/core-components-date-time-input Patch
@alfalab/core-components-file-upload-item-v1 Patch
@alfalab/core-components-file-upload-item Patch
@alfalab/core-components-gallery Patch
@alfalab/core-components-navigation-bar-private Patch
@alfalab/core-components-number-input Patch
@alfalab/core-components-password-input Patch
@alfalab/core-components-plate Patch
@alfalab/core-components-tabs Patch
@alfalab/core-components-toast-plate Patch
@alfalab/core-components-calendar-input Patch
@alfalab/core-components-calendar-range Patch
@alfalab/core-components-calendar-with-skeleton Patch
@alfalab/core-components-bottom-sheet Patch
@alfalab/core-components-modal Patch
@alfalab/core-components-popup-sheet Patch
@alfalab/core-components-side-panel Patch
@alfalab/core-components-alert Patch
@alfalab/core-components-notification Patch
@alfalab/core-components-toast Patch
@alfalab/core-components-select-with-tags Patch
@alfalab/core-components-select Patch
@alfalab/core-components-tooltip Patch
@alfalab/core-components-notification-manager Patch
@alfalab/core-components-custom-picker-button Patch
@alfalab/core-components-input-autocomplete Patch
@alfalab/core-components-international-phone-input Patch
@alfalab/core-components-intl-phone-input Patch
@alfalab/core-components-picker-button Patch
@alfalab/core-components-table Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@core-ds-bot
Copy link
Collaborator

Bundle size report

Entry point Size (minified)
tooltip/mobile.js 74.5 (-2.30 KB💚)
toast/desktop.js 65.5 (-2.60 KB💚)
toast/mobile.js 65.5 (-2.60 KB💚)
toast-plate/desktop.js 19.9 (-2.70 KB💚)
toast-plate/mobile.js 19.9 (-2.70 KB💚)
tabs/desktop.js 35.3 (-2.70 KB💚)
tabs/mobile.js 35.4 (-2.70 KB💚)
tabs/shared.js 28.7 (-2.60 KB💚)
side-panel/desktop.js 65.4 (-2.40 KB💚)
side-panel/mobile.js 63.6 (-2.30 KB💚)
popup-sheet/index.js 59 (-2.60 KB💚)
plate/desktop.js 12.9 (-2.70 KB💚)
plate/mobile.js 12.9 (-2.70 KB💚)
notification/index.js 27.3 (-2.70 KB💚)
navigation-bar-private/index.js 17.8 (-2.30 KB💚)
navigation-bar-private/shared.js 14.5 (-2.30 KB💚)
modal/desktop.js 64.4 (-2.30 KB💚)
modal/mobile.js 64.4 (-2.30 KB💚)
icon-button/index.js 8.4 (-3.00 KB💚)
file-upload-item/index.js 80.3 (-2.60 KB💚)
file-upload-item-v1/index.js 18.6 (-2.70 KB💚)
calendar/desktop.js 65.5 (-2.40 KB💚)
calendar/shared.js 46.5 (-2.40 KB💚)
calendar-with-skeleton/index.js 66.9 (-2.30 KB💚)
bottom-sheet/index.js 73.8 (-2.30 KB💚)

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@denisx denisx marked this pull request as ready for review December 21, 2024 14:52
@denisx denisx changed the title feat(icon-button): change button import feat(icon-button): change button d->m import Dec 22, 2024
Copy link
Collaborator

@fulcanellee fulcanellee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Мобильные и десктопные кнопки могут отличаться скруглением и цветом. Правки могут привести к непредвиденному поведению у того кто уже использует компонент на десктопе

@denisx
Copy link
Contributor Author

denisx commented Dec 23, 2024

@fulcanellee я не вижу в компоненте использование таких элементов кнопки. От кнопки тут только поведение/события.
прицепил ссылку на демку в описание

@denisx denisx changed the title feat(icon-button): change button d->m import feat(icon-button): change import button desktop -> mobile Dec 26, 2024
Copy link
Collaborator

@hextion hextion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

нужно подумать в сторону BaseButton

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants