Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: change deep-equal to react-fast-compare #1503

Merged
merged 7 commits into from
Dec 19, 2024
Merged

feat: change deep-equal to react-fast-compare #1503

merged 7 commits into from
Dec 19, 2024

Conversation

denisx
Copy link
Contributor

@denisx denisx commented Dec 16, 2024

Опишите проблему

Замена зависимости deep-equal на react-fast-compare. Меньше, современнее, быстрее.

Ожидаемое поведение

Без измененений
https://core-ds.github.io/core-components/feat_7758_30_1ae74433330a068042dda4436139f376e58f648f/?path=/story/select--select

Copy link

changeset-bot bot commented Dec 16, 2024

🦋 Changeset detected

Latest commit: 5f9f926

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages
Name Type
@alfalab/core-components-select Patch
@alfalab/core-components-custom-picker-button Patch
@alfalab/core-components-input-autocomplete Patch
@alfalab/core-components-international-phone-input Patch
@alfalab/core-components-intl-phone-input Patch
@alfalab/core-components-picker-button Patch
@alfalab/core-components-select-with-tags Patch
@alfalab/core-components-table Patch
@alfalab/core-components-tabs Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@core-ds-bot
Copy link
Collaborator

Bundle size report

Entry point Size (minified)
select/index.js 229.8 (-74.60 KB)
select/mobile.js 203.2 (-74.50 KB)
select/shared.js 189.4 (-74.50 KB)
picker-button/index.js 234.8 (-74.50 KB)
picker-button/mobile.js 207.5 (-74.50 KB)
international-phone-input/index.js 536.5 (-74.50 KB)
international-phone-input/mobile.js 508.6 (-74.40 KB)
input-autocomplete/index.js 236.7 (-74.50 KB)
input-autocomplete/mobile.js 209.2 (-74.50 KB)
custom-picker-button/index.js 236.7 (-74.50 KB)
custom-picker-button/mobile.js 209.1 (-74.50 KB)

@coveralls
Copy link

coveralls commented Dec 16, 2024

Pull Request Test Coverage Report for Build 12409046095

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 82.307%

Totals Coverage Status
Change from base Build 12314902408: 0.0%
Covered Lines: 10634
Relevant Lines: 11793

💛 - Coveralls

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@denisx denisx changed the title feat: up deps; feat: change deep-equal to react-fast-compare Dec 16, 2024
@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@denisx denisx marked this pull request as ready for review December 16, 2024 21:50
Denis 🎃 Khripkov added 2 commits December 17, 2024 00:53
@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

Co-authored-by: Evgeny Sergeev <[email protected]>
@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@hextion hextion merged commit 295a637 into master Dec 19, 2024
7 checks passed
@hextion hextion deleted the feat/7758_30 branch December 19, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants