feat(status-badge): add StatusBadgeBlank; without preload icons #1500
+302
−128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 3316d13 The changes in this PR will be included in the next version bump. This PR includes changesets to release 30 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
denisx
commented
Dec 15, 2024
| view: StatusBadgeViews, | ||
| size: StatusBadgeSizes, | ||
| customIcons?: StatusBadgeCustomIcon, | ||
| export const combineIcons = ( |
There was a problem hiding this comment.
Просто вытащил ф-ию из хука
Pull Request Test Coverage Report for Build 12342123994Details
💛 - Coveralls |
|
Собрана новая демка. |
denisx
requested review from
reme3d2y,
fulcanellee,
SiebenSieben and
hextion
as code owners
fulcanellee
requested changes
Dec 17, 2024
| export type IconMap = Record< | ||
| StatusBadgeViews, | ||
| Record<NonNullable<StatusBadgeSizes>, StatusBadgeIcon> | ||
| >; | ||
|
|
||
| export const ICON_MAP: IconMap = { | ||
| const ICON_MAP_16: StatusBadgeCustomIcon = { | ||
| 'positive-checkmark': { |
There was a problem hiding this comment.
Если единая мапка делится на несколько разных, которые содержат перечисления единственного размера то теряется смысл в цифрах 16: , 20: и т. д.
16: CheckmarkCompactSIcon
Suggested change
| 'positive-checkmark': { | |
| 'positive-checkmark': CheckmarkCompactSIcon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Опишите проблему
Чек лист
Внешний вид
Без изменений