Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(button): make common styles colors - base-button #1499

Closed
wants to merge 3 commits into from

Conversation

denisx
Copy link
Contributor

@denisx denisx commented Dec 14, 2024

Опишите проблему

Убрал дублирование:

  • Вынос общих стилей цветов button/base-button

Внешний вид

Без изменений

Профитность

Было:
Screenshot 2024-12-15 at 01 28 55

Стало:
Screenshot 2024-12-15 at 01 28 59

Copy link

changeset-bot bot commented Dec 14, 2024

🦋 Changeset detected

Latest commit: 4d481b2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 55 packages
Name Type
@alfalab/core-components-button Patch
@alfalab/core-components-attach Patch
@alfalab/core-components-calendar Patch
@alfalab/core-components-confirmation-v1 Patch
@alfalab/core-components-confirmation Patch
@alfalab/core-components-custom-button Patch
@alfalab/core-components-icon-button Patch
@alfalab/core-components-input Patch
@alfalab/core-components-navigation-bar-private Patch
@alfalab/core-components-navigation-bar Patch
@alfalab/core-components-pass-code-v1 Patch
@alfalab/core-components-pass-code Patch
@alfalab/core-components-pattern-lock-v1 Patch
@alfalab/core-components-pattern-lock Patch
@alfalab/core-components-picker-button Patch
@alfalab/core-components-plate Patch
@alfalab/core-components-product-cover Patch
@alfalab/core-components-pure-cell Patch
@alfalab/core-components-select Patch
@alfalab/core-components-table Patch
@alfalab/core-components-tooltip Patch
@alfalab/core-components-calendar-input Patch
@alfalab/core-components-calendar-range Patch
@alfalab/core-components-calendar-with-skeleton Patch
@alfalab/core-components-date-range-input Patch
@alfalab/core-components-date-time-input Patch
@alfalab/core-components-universal-date-input Patch
@alfalab/core-components-custom-picker-button Patch
@alfalab/core-components-file-upload-item-v1 Patch
@alfalab/core-components-file-upload-item Patch
@alfalab/core-components-gallery Patch
@alfalab/core-components-number-input Patch
@alfalab/core-components-password-input Patch
@alfalab/core-components-tabs Patch
@alfalab/core-components-toast-plate Patch
@alfalab/core-components-amount-input Patch
@alfalab/core-components-date-input Patch
@alfalab/core-components-input-autocomplete Patch
@alfalab/core-components-international-phone-input Patch
@alfalab/core-components-masked-input Patch
@alfalab/core-components-slider-input Patch
@alfalab/core-components-time-input Patch
@alfalab/core-components-with-suffix Patch
@alfalab/core-components-bottom-sheet Patch
@alfalab/core-components-modal Patch
@alfalab/core-components-popup-sheet Patch
@alfalab/core-components-side-panel Patch
@alfalab/core-components-alert Patch
@alfalab/core-components-intl-phone-input Patch
@alfalab/core-components-select-with-tags Patch
@alfalab/core-components-notification Patch
@alfalab/core-components-toast Patch
@alfalab/core-components-bank-card Patch
@alfalab/core-components-phone-input Patch
@alfalab/core-components-notification-manager Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coveralls
Copy link

coveralls commented Dec 14, 2024

Pull Request Test Coverage Report for Build 12369739799

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 82.307%

Totals Coverage Status
Change from base Build 12314902408: 0.0%
Covered Lines: 10634
Relevant Lines: 11793

💛 - Coveralls

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@denisx denisx marked this pull request as ready for review December 14, 2024 23:12
import commonStyles from './index.module.css';
import invertedColors from './inverted.module.css';

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Не нашел импорта нового файла в ts colors.common.module.css

вынесенные стили точно применились?

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@core-ds core-ds deleted a comment from core-ds-bot Dec 17, 2024
@denisx
Copy link
Contributor Author

denisx commented Dec 17, 2024

Ещё раз пересчитал результатность. Профит неясный. Пока закрою

@denisx denisx closed this Dec 17, 2024
@denisx
Copy link
Contributor Author

denisx commented Dec 17, 2024

Зато отловил зависимые пакеты под переделку в д/м )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants