-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(typography): organize folders/files #1498
Open
denisx
wants to merge
3
commits into
master
Choose a base branch
from
feat/DS-7758_26
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
'@alfalab/core-components-typography': patch | ||
--- | ||
|
||
- Внутренний рефакторинг: приведена в порядок структура папок |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
import type { FC, ForwardRefExoticComponent, RefAttributes } from 'react'; | ||
|
||
import type { TitleProps } from './title/component'; | ||
import { type TitleResponsiveProps, TitleResponsive } from './title/component.responsive'; | ||
import { Title } from './title/desktop'; | ||
import { type TitleMobileProps, TitleMobile } from './title/mobile'; | ||
import { type TextProps, Text } from './text'; | ||
import type { TextElementType } from './types'; | ||
|
||
export const Typography: { | ||
Title: FC<TitleProps>; | ||
Text: ForwardRefExoticComponent<TextProps & RefAttributes<TextElementType>>; | ||
TitleResponsive: FC<TitleResponsiveProps>; | ||
TitleMobile: FC<TitleMobileProps>; | ||
} = { | ||
Title, | ||
Text, | ||
TitleResponsive, | ||
TitleMobile, | ||
}; | ||
|
||
export { Text, Title as TitleDesktop, TitleResponsive, TitleMobile }; |
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
export * from './component'; | ||
export * from './presets'; | ||
export type { TitleProps } from './title'; | ||
export type { TitleProps } from './title/component'; | ||
export type { TextProps } from './text'; | ||
export type { Color } from './colors'; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 changes: 3 additions & 2 deletions
5
...s/typography/src/title/component.test.tsx → ...aphy/src/title/desktop/component.test.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 changes: 2 additions & 5 deletions
7
packages/typography/src/title/index.tsx → ...ypography/src/title/desktop/component.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,18 +1,15 @@ | ||
import React, { forwardRef } from 'react'; | ||
|
||
import { TitleBase, TitleProps } from './component'; | ||
import { type TitleProps, TitleBase } from '../component'; | ||
|
||
import commonStyles from './common.module.css'; | ||
import styles from './index.module.css'; | ||
|
||
const Title = forwardRef<HTMLHeadingElement | HTMLDivElement, TitleProps>((props, ref) => ( | ||
export const Title = forwardRef<HTMLHeadingElement | HTMLDivElement, TitleProps>((props, ref) => ( | ||
<TitleBase | ||
{...props} | ||
styles={Object.assign(commonStyles, styles)} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
ref={ref} | ||
platform='desktop' | ||
/> | ||
)); | ||
|
||
export { Title }; | ||
export type { TitleProps }; |
6 changes: 3 additions & 3 deletions
6
...ges/typography/src/title/index.module.css → ...graphy/src/title/desktop/index.module.css
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
2 changes: 1 addition & 1 deletion
2
...tle-mobile/component.screenshots.test.tsx → ...tle/mobile/component.screenshots.test.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 2 additions & 2 deletions
4
...typography/src/title-mobile/component.tsx → ...typography/src/title/mobile/component.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 2 additions & 2 deletions
4
...ography/src/title-mobile/index.module.css → ...ography/src/title/mobile/index.module.css
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
export { TitleMobile } from './component'; | ||
export type { TitleProps as TitleMobileProps } from '../component'; |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
файл переименован tsx -> ts