-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(issue template): новый формат шаблона создания реквестов #1485
Open
Oladii
wants to merge
2
commits into
master
Choose a base branch
from
Oladii-patch-3
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,38 +1,34 @@ | ||
--- | ||
name: Предложить улучшение | ||
about: Создайте отчет, это поможет нам улучшить наш проект | ||
title: '' | ||
labels: '' | ||
assignees: '' | ||
|
||
--- | ||
|
||
# Описание | ||
Предлагаю добавить новую кнопку | ||
Кратко сформулируйте суть доработки | ||
|
||
# Поведение | ||
При нажатии на кнопку должно появится модальное окно | ||
Пример: Предлагаю добавить новый вид кнопки со скруглениями только сверху. | ||
При включении пропсы halfRounded нижние углы игнорируют применённое скругление. | ||
Задача: https://.../DS-1234 | ||
|
||
# Чек лист | ||
- [ ] Тесты | ||
- [ ] Документация | ||
- [ ] У реквеста осмысленное название feat(...): или fix(...): | ||
- [ ] Задача сформулирована и описана в JIRA | ||
- [ ] Ссылка на задачу добавлена в реквест | ||
- [ ] В задаче указаны команды, которые ждут это обновление | ||
- [ ] Код покрыт тестами и протестирован в различных браузерах | ||
- [ ] Изменения описаны в документации | ||
- [ ] К реквесту добавлен ченжсет | ||
|
||
# Внешний вид | ||
Если есть визуальные изменения | ||
- [ ] В задаче указан дизайнер к которому можно обратиться с вопросами | ||
|
||
# Технические требования | ||
Если минорка | ||
- [ ] Есть апрув от еще одного представителя твоего продукта | ||
|
||
## Десктоп (если данных нет оставьте блок пустым): | ||
- OS: MacOS | ||
- Browser: Safari | ||
- Version: 10 | ||
Если мажорка | ||
- [ ] Есть апрувы от представителей веб-команд. 1 дизайнер и 1 фронт от каждой из перечисленных команд: Core, AO, Corp, Site | ||
- [ ] Выпущена бетка, прикреплена ссылка на неё | ||
|
||
## Смартфон (если данных нет оставьте блок пустым): | ||
- Device: iPhone 6 | ||
- OS: iOS 10 | ||
- Browser: Chrome | ||
- Version: 65 | ||
Если темизация | ||
- [ ] Есть апрувы от представителей затрагиваемой темы: 1 дизайнер и 1 фронт | ||
|
||
Если реквест касается инструментов: плагинов, библиотек и тд | ||
- [ ] Есть файл Readme, описывающий логику их работы | ||
|
||
# Дополнительная информация | ||
Дополнительная информация | ||
|
||
## Stage - 0 |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Тут только про кор-компоненты, надо убрать