Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: classname update to 2.5.1 #1478

Merged
merged 4 commits into from
Dec 11, 2024
Merged

feat: classname update to 2.5.1 #1478

merged 4 commits into from
Dec 11, 2024

Conversation

denisx
Copy link
Contributor

@denisx denisx commented Dec 1, 2024

Опишите проблему

В последних версиях вендора произведена оптимизация по скорости работы.

Негативной изменение в размере: пакеты проверяются каждый отдельно. В сборке они будут смержены вместе по минорке.

P.S. Прошу заметить, что те пакеты, в которых уже выставлено side effects, не показали отрицательного роста (например Typography) это потому что пакет classnames получил дополнительные импорты, но использоваться в проде они не будут, когда side effect доедет до всех пакетов в кор-компоненты. Хотя даже в текущем исполнении, этот апдейт не принесёт доп нагрузки для сборки - потому что зависимость с шапочкой

Ожидаемое поведение

Без изменений

Copy link

changeset-bot bot commented Dec 1, 2024

🦋 Changeset detected

Latest commit: 20a3281

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 110 packages
Name Type
@alfalab/core-components-accordion Patch
@alfalab/core-components-action-button Patch
@alfalab/core-components-alert Patch
@alfalab/core-components-amount Patch
@alfalab/core-components-amount-input Patch
@alfalab/core-components-attach Patch
@alfalab/core-components-backdrop Patch
@alfalab/core-components-badge Patch
@alfalab/core-components-bank-card Patch
@alfalab/core-components-base-modal Patch
@alfalab/core-components-bottom-sheet Patch
@alfalab/core-components-button Patch
@alfalab/core-components-calendar Patch
@alfalab/core-components-calendar-input Patch
@alfalab/core-components-calendar-range Patch
@alfalab/core-components-calendar-with-skeleton Patch
@alfalab/core-components-card-image Patch
@alfalab/core-components-cdn-icon Patch
@alfalab/core-components-chart Patch
@alfalab/core-components-checkbox Patch
@alfalab/core-components-checkbox-group Patch
@alfalab/core-components-circular-progress-bar Patch
@alfalab/core-components-code-input Patch
@alfalab/core-components-collapse Patch
@alfalab/core-components-comment Patch
@alfalab/core-components-confirmation Patch
@alfalab/core-components-confirmation-v1 Patch
@alfalab/core-components-custom-button Patch
@alfalab/core-components-custom-picker-button Patch
@alfalab/core-components-date-range-input Patch
@alfalab/core-components-date-time-input Patch
@alfalab/core-components-divider Patch
@alfalab/core-components-drawer Patch
@alfalab/core-components-dropzone Patch
@alfalab/core-components-file-upload-item Patch
@alfalab/core-components-file-upload-item-v1 Patch
@alfalab/core-components-filter-tag Patch
@alfalab/core-components-form-control Patch
@alfalab/core-components-gallery Patch
@alfalab/core-components-gap Patch
@alfalab/core-components-generic-wrapper Patch
@alfalab/core-components-grid Patch
@alfalab/core-components-hatching-progress-bar Patch
@alfalab/core-components-icon-button Patch
@alfalab/core-components-icon-view Patch
@alfalab/core-components-indicator Patch
@alfalab/core-components-input Patch
@alfalab/core-components-input-autocomplete Patch
@alfalab/core-components-international-phone-input Patch
@alfalab/core-components-intl-phone-input Patch
@alfalab/core-components-link Patch
@alfalab/core-components-list Patch
@alfalab/core-components-list-header Patch
@alfalab/core-components-loader Patch
@alfalab/core-components-markdown Patch
@alfalab/core-components-masked-input Patch
@alfalab/core-components-modal Patch
@alfalab/core-components-navigation-bar Patch
@alfalab/core-components-navigation-bar-private Patch
@alfalab/core-components-notification Patch
@alfalab/core-components-notification-manager Patch
@alfalab/core-components-number-input Patch
@alfalab/core-components-pagination Patch
@alfalab/core-components-pass-code Patch
@alfalab/core-components-pass-code-v1 Patch
@alfalab/core-components-password-input Patch
@alfalab/core-components-pattern-lock Patch
@alfalab/core-components-pattern-lock-v1 Patch
@alfalab/core-components-picker-button Patch
@alfalab/core-components-plate Patch
@alfalab/core-components-popover Patch
@alfalab/core-components-popup-sheet Patch
@alfalab/core-components-product-cover Patch
@alfalab/core-components-progress-bar Patch
@alfalab/core-components-pure-cell Patch
@alfalab/core-components-radio Patch
@alfalab/core-components-radio-group Patch
@alfalab/core-components-scrollbar Patch
@alfalab/core-components-segmented-control Patch
@alfalab/core-components-select Patch
@alfalab/core-components-select-with-tags Patch
@alfalab/core-components-side-panel Patch
@alfalab/core-components-skeleton Patch
@alfalab/core-components-slider Patch
@alfalab/core-components-slider-input Patch
@alfalab/core-components-sortable-list Patch
@alfalab/core-components-space Patch
@alfalab/core-components-spinner Patch
@alfalab/core-components-status Patch
@alfalab/core-components-status-badge Patch
@alfalab/core-components-stepped-progress-bar Patch
@alfalab/core-components-steps Patch
@alfalab/core-components-switch Patch
@alfalab/core-components-system-message Patch
@alfalab/core-components-tab-bar Patch
@alfalab/core-components-table Patch
@alfalab/core-components-tabs Patch
@alfalab/core-components-tag Patch
@alfalab/core-components-text Patch
@alfalab/core-components-textarea Patch
@alfalab/core-components-toast Patch
@alfalab/core-components-toast-plate Patch
@alfalab/core-components-tooltip Patch
@alfalab/core-components-typography Patch
@alfalab/core-components-underlay Patch
@alfalab/core-components-universal-date-input Patch
@alfalab/core-components-with-suffix Patch
@alfalab/core-components-date-input Patch
@alfalab/core-components-time-input Patch
@alfalab/core-components-phone-input Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@core-ds-bot
Copy link
Collaborator

Bundle size report

Entry point Size (minified)
universal-date-input/desktop.js 145.4 (+4.30 KB🔺)
universal-date-input/index.js 145.5 (+4.20 KB🔺)
universal-date-input/mobile.js 145.4 (+4.30 KB🔺)
tooltip/index.js 114.6 (+7.10 KB🔺)
tooltip/mobile.js 85.2 (+6.30 KB🔺)
toast/desktop.js 72.7 (+4.30 KB🔺)
toast/index.js 73.2 (+4.30 KB🔺)
toast/mobile.js 72.7 (+4.30 KB🔺)
toast-plate/desktop.js 25.8 (+2.80 KB🔺)
toast-plate/index.js 26.2 (+2.90 KB🔺)
toast-plate/mobile.js 25.8 (+2.80 KB🔺)
time-input/index.js 30 (+2.90 KB🔺)
tabs/collapsible.js 302.9 (+9.90 KB🔺)
tabs/desktop.js 40.7 (+3.60 KB🔺)
tabs/index.js 42 (+3.50 KB🔺)
tabs/mobile.js 40.8 (+3.60 KB🔺)
tabs/shared.js 32.6 (+2.20 KB🔺)
table/index.js 180.9 (+8.40 KB🔺)
tab-bar/index.js 14.6 (+2.20 KB🔺)
slider-input/index.js 61.1 (+4.30 KB🔺)
side-panel/desktop.js 76.2 (+6.40 KB🔺)
side-panel/index.js 77.8 (+6.30 KB🔺)
side-panel/mobile.js 73.6 (+5.60 KB🔺)
select/desktop.js 167.3 (+6.40 KB🔺)
select/index.js 317.8 (+11.90 KB🔺)
select/mobile.js 290.4 (+11.20 KB🔺)
select/shared.js 271.8 (+7.80 KB🔺)
select-with-tags/desktop.js 299.6 (+9.80 KB🔺)
select-with-tags/index.js 326.8 (+12.60 KB🔺)
select-with-tags/mobile.js 300 (+12.00 KB🔺)
pure-cell/index.js 51.6 (+4.30 KB🔺)
product-cover/index.js 43.6 (+2.80 KB🔺)
popup-sheet/index.js 67.6 (+4.30 KB🔺)
plate/desktop.js 18.1 (+2.20 KB🔺)
plate/index.js 18.5 (+2.20 KB🔺)
plate/mobile.js 18.1 (+2.20 KB🔺)
picker-button/desktop.js 294.2 (+9.20 KB🔺)
picker-button/index.js 332.3 (+12.60 KB🔺)
picker-button/mobile.js 304.4 (+12.00 KB🔺)
phone-input/index.js 40.9 (+3.60 KB🔺)
password-input/index.js 34.3 (+4.30 KB🔺)
pass-code/index.js 25.6 (+2.10 KB🔺)
pass-code-v1/index.js 21.9 (+2.10 KB🔺)
number-input/desktop.js 48.1 (+4.20 KB🔺)
number-input/index.js 48.9 (+4.30 KB🔺)
number-input/mobile.js 48.1 (+4.20 KB🔺)
notification/index.js 33.8 (+3.50 KB🔺)
navigation-bar/shared.js 18.8 (+2.80 KB🔺)
navigation-bar-private/index.js 25.3 (+3.50 KB🔺)
navigation-bar-private/shared.js 22 (+3.50 KB🔺)
modal/desktop.js 74.4 (+5.70 KB🔺)
modal/index.js 74.5 (+5.60 KB🔺)
modal/mobile.js 74.4 (+5.70 KB🔺)
masked-input/index.js 39.1 (+3.50 KB🔺)
markdown/desktop.js 130.6 (+2.90 KB🔺)
markdown/index.js 130.7 (+2.90 KB🔺)
markdown/mobile.js 130.6 (+2.90 KB🔺)
intl-phone-input/index.js 803.2 (+9.90 KB🔺)
international-phone-input/desktop.js 592.8 (+9.90 KB🔺)
international-phone-input/index.js 631.5 (+13.40 KB🔺)
international-phone-input/mobile.js 602.8 (+12.60 KB🔺)
international-phone-input/shared.js 262.4 (+7.80 KB🔺)
input/desktop.js 28.5 (+2.80 KB🔺)
input/index.js 29.1 (+2.80 KB🔺)
input/mobile.js 28.5 (+2.80 KB🔺)
input-autocomplete/desktop.js 290.8 (+9.20 KB🔺)
input-autocomplete/index.js 331.1 (+12.60 KB🔺)
input-autocomplete/mobile.js 303 (+12.00 KB🔺)
gallery/index.js 632.1 (+7.00 KB🔺)
file-upload-item/index.js 87.9 (+4.20 KB🔺)
file-upload-item-v1/index.js 24.5 (+2.90 KB🔺)
date-time-input/desktop.js 151.1 (+5.70 KB🔺)
date-time-input/index.js 256.4 (+9.90 KB🔺)
date-time-input/mobile.js 255.7 (+9.90 KB🔺)
date-range-input/desktop.js 151.6 (+5.70 KB🔺)
date-range-input/index.js 256.9 (+9.80 KB🔺)
date-range-input/mobile.js 256.3 (+9.90 KB🔺)
date-input/index.js 74 (+2.90 KB🔺)
custom-picker-button/desktop.js 297.2 (+10.50 KB🔺)
custom-picker-button/index.js 335.6 (+14.00 KB🔺)
custom-picker-button/mobile.js 307.4 (+13.40 KB🔺)
confirmation/desktop.js 36.4 (+4.30 KB🔺)
confirmation/index.js 36.7 (+4.20 KB🔺)
confirmation/mobile.js 36.5 (+4.30 KB🔺)
confirmation/shared.js 34.8 (+4.30 KB🔺)
confirmation-v1/index.js 47.7 (+2.80 KB🔺)
chart/index.js 444.3 (+2.10 KB🔺)
calendar/desktop.js 70.4 (+2.20 KB🔺)
calendar/index.js 184.9 (+6.30 KB🔺)
calendar/mobile.js 184.8 (+6.40 KB🔺)
calendar/shared.js 51.4 (+2.20 KB🔺)
calendar-with-skeleton/index.js 73.1 (+3.60 KB🔺)
calendar-range/index.js 265.3 (+10.50 KB🔺)
calendar-input/desktop.js 152.6 (+5.70 KB🔺)
calendar-input/index.js 257.5 (+9.90 KB🔺)
calendar-input/mobile.js 257.2 (+9.80 KB🔺)
calendar-input/shared.js 78.6 (+4.30 KB🔺)
bottom-sheet/index.js 83.8 (+5.60 KB🔺)
bank-card/index.js 46.9 (+4.20 KB🔺)
attach/index.js 39.6 (+2.20 KB🔺)
amount-input/index.js 59.8 (+4.20 KB🔺)
alert/index.js 19.4 (+2.80 KB🔺)

@coveralls
Copy link

coveralls commented Dec 1, 2024

Pull Request Test Coverage Report for Build 12260750012

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 82.302%

Totals Coverage Status
Change from base Build 12256710958: 0.0%
Covered Lines: 10630
Relevant Lines: 11790

💛 - Coveralls

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@denisx denisx marked this pull request as ready for review December 2, 2024 09:51
.changeset/chilly-badgers-hear.md Outdated Show resolved Hide resolved
change minor -> patch
@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@hextion hextion merged commit dd16ec8 into master Dec 11, 2024
7 checks passed
@hextion hextion deleted the feat/DS-7758_13 branch December 11, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants