-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: classname update to 2.5.1 #1478
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 20a3281 The changes in this PR will be included in the next version bump. This PR includes changesets to release 110 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Bundle size report
|
denisx
commented
Dec 1, 2024
Pull Request Test Coverage Report for Build 12260750012Details
💛 - Coveralls |
Собрана новая демка. |
denisx
requested review from
reme3d2y,
fulcanellee,
SiebenSieben and
hextion
as code owners
December 2, 2024 09:51
fulcanellee
approved these changes
Dec 3, 2024
hextion
requested changes
Dec 3, 2024
reme3d2y
approved these changes
Dec 5, 2024
change minor -> patch
Собрана новая демка. |
Собрана новая демка. |
hextion
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Опишите проблему
В последних версиях вендора произведена оптимизация по скорости работы.
Негативной изменение в размере: пакеты проверяются каждый отдельно. В сборке они будут смержены вместе по минорке.
P.S. Прошу заметить, что те пакеты, в которых уже выставлено side effects, не показали отрицательного роста (например Typography) это потому что пакет classnames получил дополнительные импорты, но использоваться в проде они не будут, когда side effect доедет до всех пакетов в кор-компоненты. Хотя даже в текущем исполнении, этот апдейт не принесёт доп нагрузки для сборки - потому что зависимость с шапочкой
Ожидаемое поведение
Без изменений