Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: move to common lodash package; #1477

Merged
merged 11 commits into from
Dec 11, 2024
Merged

feat: move to common lodash package; #1477

merged 11 commits into from
Dec 11, 2024

Conversation

denisx
Copy link
Contributor

@denisx denisx commented Dec 1, 2024

Опишите проблему

Переход на единый lodash пакет. В продуктовом использовании единый пакет доставляет меньше нагрузки на бандл, чем атомарные, т.к. устанавливается множество несинхронный версий, в отличие от lodash в resolution
Сами импорты из пакета не дают лишний вес сборки, при использовании таким образом: "import foo from lodash/foo"

Изменённые пакеты: Сollapse, Autocomplete, Tabs

Откуда лишний размер в графике: плагин показывает размер атомарно, без учета общей сборки проекта.

Ожидаемое поведение

Без изменений

Copy link

changeset-bot bot commented Dec 1, 2024

🦋 Changeset detected

Latest commit: 3dceabb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@alfalab/core-components-collapse Patch
@alfalab/core-components-input-autocomplete Patch
@alfalab/core-components-tabs Patch
@alfalab/core-components-international-phone-input Patch
@alfalab/core-components-intl-phone-input Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@core-ds-bot
Copy link
Collaborator

core-ds-bot commented Dec 1, 2024

Bundle size report

Entry point Size (minified)
international-phone-input/index.js 612.2 (+3.10 KB🔺)
international-phone-input/mobile.js 584.2 (+3.10 KB🔺)
input-autocomplete/index.js 312.4 (+3.10 KB🔺)
input-autocomplete/mobile.js 284.9 (+3.10 KB🔺)

@coveralls
Copy link

coveralls commented Dec 1, 2024

Pull Request Test Coverage Report for Build 12175988203

Details

  • 3 of 3 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 82.403%

Totals Coverage Status
Change from base Build 12069391778: 0.0%
Covered Lines: 10620
Relevant Lines: 11766

💛 - Coveralls

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@denisx denisx marked this pull request as ready for review December 2, 2024 17:14
.changeset/beige-kangaroos-try.md Outdated Show resolved Hide resolved
Change minor -> patch
@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@hextion hextion merged commit 88afc0d into master Dec 11, 2024
7 checks passed
@hextion hextion deleted the feat/DS-7758_12 branch December 11, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants