Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/fullscreen vertical scroll #1463

Merged
merged 3 commits into from
Nov 25, 2024
Merged

Conversation

ViralLka
Copy link
Contributor

@ViralLka ViralLka commented Nov 22, 2024

Опишите проблему

Исправила баг с вертикальным скроллом в полноэкранном режиме в галерее, он пару месяцев отсутствовал

Шаги для воспроизведения

  1. Перейти на страницу '...'
  2. Нажать на кнопку '...'

Ожидаемое поведение

При нажатии на кнопку должно появится модальное окно

Чек лист

  • Тесты
  • Документация

Внешний вид

Ожидаемый Фактический
** Ожидаемый ** ** Фактический **

Тестовый стенд

Десктоп (если данных нет оставте блок пустым):

  • OS: MacOS
  • Browser: Safari
  • Version: 10

Смартфон (если данных нет оставте блок пустым):

  • Device: iPhone 6
  • OS: iOS 10
  • Browser: Chrome
  • Version: 65

Дополнительная информация

Дополнительная информация

Copy link

changeset-bot bot commented Nov 22, 2024

🦋 Changeset detected

Latest commit: a32ff7e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@alfalab/core-components-gallery Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coveralls
Copy link

coveralls commented Nov 22, 2024

Pull Request Test Coverage Report for Build 11975803075

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 82.403%

Totals Coverage Status
Change from base Build 11959593160: 0.0%
Covered Lines: 10616
Relevant Lines: 11762

💛 - Coveralls

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@temss-front
Copy link
Contributor

image_2024-11-22_16-40-39
в мобилке надо оставить как было, уезжает из-за абсолютно позиционированной навигации

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@ViralLka
Copy link
Contributor Author

Добавила новый класс для мобилы

@SiebenSieben SiebenSieben merged commit 9153791 into master Nov 25, 2024
7 checks passed
@SiebenSieben SiebenSieben deleted the fix/fullscreen-vertical-scroll branch November 25, 2024 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants