feat: add core-config #1426
Merged
feat: add core-config #1426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 5818ccc The changes in this PR will be included in the next version bump. This PR includes changesets to release 56 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
reme3d2y
commented
Oct 24, 2024
| }; | ||
|
|
||
| export const CoreConfigContext = createContext<CoreConfigContext>({ | ||
| breakpoint: 1024, |
There was a problem hiding this comment.
Можно перенести getComponentBreakpoint из shared и добавить сюда.
Но я бы выпилил это и оставил только решение с провайдером.
При использовании standalone компонентов без контекста — будут дефолтные значения, которые можно будет переопределить через пропсы компонента
hextion
reviewed
Oct 24, 2024
fulcanellee
approved these changes
Oct 24, 2024
reme3d2y
force-pushed
the
feat/core-config
branch
from
0b1e8f9 to
1d894a3
Compare
reme3d2y
force-pushed
the
feat/core-config
branch
from
6e371d4 to
2545fa1
Compare
|
Собрана новая демка. |
hextion
approved these changes
Oct 28, 2024
reme3d2y
force-pushed
the
feat/core-config
branch
from
602a317 to
13b1815
Compare
|
Собрана новая демка. |
|
Собрана новая демка. |
Pull Request Test Coverage Report for Build 11893072774Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
|
Собрана новая демка. |
hextion
approved these changes
Nov 1, 2024
hextion
requested changes
Nov 5, 2024
| @@ -74,20 +74,15 @@ export const Textarea = forwardRef<HTMLTextAreaElement, TextareaProps>( | |||
|
|
|||
| nativeScrollbar = Boolean(nativeScrollbarProp ?? nativeScrollbar); | |||
|
|
|||
| const textareaRef = useRef<HTMLTextAreaElement>(null); | |||
| const [textareaNode, setTextareaNode] = useState<HTMLTextAreaElement | null>(null); | |||
hextion
force-pushed
the
feat/core-config
branch
from
5c850c1 to
0d64d33
Compare
|
Собрана новая демка. |
SiebenSieben
approved these changes
Nov 18, 2024
hextion
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.