Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(input): prevent input of [eE] characters #1422

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

fulcanellee
Copy link
Collaborator

https://rc.alfa-bank.net/channel/core-components-support/thread/JWgyzxj2PG7pT9cW7?msg=JWgyzxj2PG7pT9cW7

Предотвращает ввод символов [eE] в input[type=number]

Copy link

changeset-bot bot commented Oct 21, 2024

🦋 Changeset detected

Latest commit: c60ae30

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 25 packages
Name Type
@alfalab/core-components-input Minor
@alfalab/core-components-amount-input Patch
@alfalab/core-components-date-input Patch
@alfalab/core-components-date-range-input Patch
@alfalab/core-components-date-time-input Patch
@alfalab/core-components-input-autocomplete Patch
@alfalab/core-components-international-phone-input Patch
@alfalab/core-components-masked-input Patch
@alfalab/core-components-number-input Patch
@alfalab/core-components-password-input Patch
@alfalab/core-components-select Patch
@alfalab/core-components-slider-input Patch
@alfalab/core-components-time-input Patch
@alfalab/core-components-universal-date-input Patch
@alfalab/core-components-with-suffix Patch
@alfalab/core-components-calendar-input Patch
@alfalab/core-components-calendar-range Patch
@alfalab/core-components-intl-phone-input Patch
@alfalab/core-components-bank-card Patch
@alfalab/core-components-phone-input Patch
@alfalab/core-components-custom-picker-button Patch
@alfalab/core-components-picker-button Patch
@alfalab/core-components-select-with-tags Patch
@alfalab/core-components-table Patch
@alfalab/core-components-tabs Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coveralls
Copy link

coveralls commented Oct 21, 2024

Pull Request Test Coverage Report for Build 11743706852

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 10 of 11 (90.91%) changed or added relevant lines in 1 file are covered.
  • 50 unchanged lines in 11 files lost coverage.
  • Overall coverage decreased (-0.02%) to 82.573%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/input/src/components/base-input/Component.tsx 10 11 90.91%
Files with Coverage Reduction New Missed Lines %
packages/calendar/src/components/calendar-mobile/Component.tsx 1 35.51%
packages/calendar/src/desktop/Component.desktop.tsx 1 96.25%
packages/select/src/components/base-select/components/list-mobile/list-bottom-sheet-mobile.tsx 1 83.33%
packages/select/src/components/base-select/components/list-mobile/list-modal-mobile.tsx 3 69.64%
packages/gallery/src/Component.tsx 4 81.2%
packages/base-modal/src/helpers/lockScroll.ts 4 54.55%
packages/select/src/components/options-list/Component.tsx 5 74.83%
packages/tooltip/src/desktop/Component.desktop.tsx 6 88.41%
packages/input/src/components/base-input/Component.tsx 6 91.82%
packages/select/src/presets/useSelectWithApply/hook.tsx 7 69.49%
Totals Coverage Status
Change from base Build 11348744922: -0.02%
Covered Lines: 10380
Relevant Lines: 11498

💛 - Coveralls

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

Copy link
Contributor

@reme3d2y reme3d2y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

вставить 2e5 все еще можно

@fulcanellee
Copy link
Collaborator Author

вставить 2e5 все еще можно

Исправил

@fulcanellee fulcanellee requested a review from reme3d2y November 7, 2024 08:14
@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@fulcanellee fulcanellee requested a review from reme3d2y November 8, 2024 14:12
@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@fulcanellee fulcanellee force-pushed the fix/input_label_position branch from 7eb34cd to c60ae30 Compare November 11, 2024 06:13
@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants