Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(select): fixed issue in selected group options #1420

Merged
merged 1 commit into from
Oct 23, 2024
Merged

fix(select): fixed issue in selected group options #1420

merged 1 commit into from
Oct 23, 2024

Conversation

NikitaRodyukov
Copy link
Contributor

No description provided.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Oct 21, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 48d305e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages
Name Type
@alfalab/core-components-select Patch
@alfalab/core-components-custom-picker-button Patch
@alfalab/core-components-input-autocomplete Patch
@alfalab/core-components-international-phone-input Patch
@alfalab/core-components-intl-phone-input Patch
@alfalab/core-components-picker-button Patch
@alfalab/core-components-select-with-tags Patch
@alfalab/core-components-table Patch
@alfalab/core-components-tabs Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coveralls
Copy link

coveralls commented Oct 21, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11454434335

Details

  • 1 of 4 (25.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.004%) to 82.586%
Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/select/src/components/options-list/Component.tsx 1 4 25.0%
Totals Coverage Status
Change from base Build 11348744922: -0.004%
Covered Lines: 10347
Relevant Lines: 11459
💛 - Coveralls

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@NikitaRodyukov NikitaRodyukov marked this pull request as ready for review October 21, 2024 11:51
@NikitaRodyukov NikitaRodyukov force-pushed the fix/select-group-select-items branch from ad83e48 to 3263d52 Compare October 21, 2024 12:08
hextion
hextion reviewed Oct 21, 2024
View reviewed changes
packages/select/src/components/options-list/Component.tsx Outdated
),
(
selectedItems?.filter(({ key: selectedItemKey }) =>
group.options.some((option) => option.key === selectedItemKey),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

отрицание не упущено?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

поправил

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@NikitaRodyukov NikitaRodyukov force-pushed the fix/select-group-select-items branch from 3263d52 to 48d305e Compare October 22, 2024 06:21
@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@hextion hextion merged commit 0cd0536 into master Oct 23, 2024
7 checks passed
@hextion hextion deleted the fix/select-group-select-items branch October 23, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fulcanellee fulcanellee fulcanellee approved these changes

@hextion hextion hextion approved these changes

@reme3d2y reme3d2y reme3d2y approved these changes

@SiebenSieben SiebenSieben Awaiting requested review from SiebenSieben SiebenSieben is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@NikitaRodyukov @coveralls @core-ds-bot @reme3d2y @hextion @fulcanellee