chore / Add "sideEffects" to package.json files #1394
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aychernov
requested review from
reme3d2y,
fulcanellee,
SiebenSieben and
hextion
as code owners
🦋 Changeset detectedLatest commit: dfd02eb The changes in this PR will be included in the next version bump. This PR includes changesets to release 117 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Bundle size report
|
aychernov
changed the title
Pull Request Test Coverage Report for Build 11440080597Details
💛 - Coveralls |
|
Собрана новая демка. |
|
@aychernov точно все пакеты идут без sideEffect? кажется есть которые в глобал что-то пишут, вроде глобал стора для модалок кажется. уточни пож-та |
Привет! Можешь ли подробнее рассказать? Не совсем понял про что ты. Имеешь ввиду что некоторые по умолчанию в себя это включают? |
hextion
approved these changes
Sep 27, 2024
fulcanellee
approved these changes
Sep 30, 2024
|
Собрана новая демка. |
ElfistIO
approved these changes
Oct 14, 2024
|
Собрана новая демка. |
|
Собрана новая демка. |
|
Собрана новая демка. |
fix(select): fixed issue in selected group options
* feat(button): redesign for corp * feat(form-control): redesign for corp * feat(code-input): redesign for corp * feat(icon-button): redesign for corp * feat(select): redesign for corp * feat(toast): redesign for corp * docs: add changeset * feat(code-input): improve after code review * feat(form-control): improve after code review * feat: improve after code review * feat(form-control): add screenshot test * feat(universal-date-input): improve after code review * feat(calendar): redesign for corp * feat: fix after merge conflict * feat(calendar): redesign for corp * feat(form-control): redesign for corp 3 * feat(code-input): redesign for corp 3 * feat(button): redesign for corp 3 * feat(icon-button): redesign for corp 3 * feat(tag): redesign for corp 3 * feat(calendar): redesign for corp 3 * feat(plate): redesign for corp 3 * feat: update changeset * feat: update screenshots * feat(plate): fix lint
* feat: improve gaps for tag, filter tag * feat: update screenshots * feat: improve gaps for tag, filter tag
|
Собрана новая демка. |
|
почему-то едут скрины. предлагаю делать кусочками по 5-10 виджетов |
This was referenced Dec 2, 2024
|
@hextion этот закрываем? |
Да, неактуально |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chore
"sideEffects": falseко всемpackage.json, для tree shaking