Feat/status sizes #1346
Merged
Feat/status sizes #1346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fulcanellee
requested review from
reme3d2y,
churicheva-v,
SiebenSieben and
hextion
as code owners
🦋 Changeset detectedLatest commit: d40e3c0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Pull Request Test Coverage Report for Build 10628555429Details
💛 - Coveralls |
|
Собрана новая демка. |
Oladii
approved these changes
Aug 28, 2024
…tatus_sizes # Conflicts: # packages/status/src/__image_snapshots__/status-dark-preview-snap.png
|
Собрана новая демка. |
hextion
approved these changes
Aug 30, 2024
churicheva-v
reviewed
Sep 2, 2024
| @@ -0,0 +1,2 @@ | |||
| export const colors = ['green', 'orange', 'red', 'blue', 'grey', 'teal', 'purple'] as const; | |||
| export const sizes = [20, 24, 32, 40] as const; | |||
There was a problem hiding this comment.
константы обычно пишем заглавными буквами
churicheva-v
approved these changes
Sep 2, 2024
reme3d2y
approved these changes
Sep 2, 2024
fulcanellee
added a commit
that referenced
this pull request
Sep 2, 2024
This reverts commit ce5878c.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.