fix(icon-view): fixed CDNIcon size (#890)

core-ds · Oct 10, 2023 · f83ccb5 · f83ccb5
1 parent 13e92eb
commit f83ccb5
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 3 deletions.
diff --git a/.changeset/spotty-jokes-reply.md b/.changeset/spotty-jokes-reply.md
@@ -0,0 +1,6 @@
+---
+'@alfalab/core-components-cdn-icon': patch
+'@alfalab/core-components-icon-view': patch
+---
+
+CDNIcon теперь занимает всю ширину и высоту IconView
diff --git a/packages/cdn-icon/src/Component.tsx b/packages/cdn-icon/src/Component.tsx
@@ -57,10 +57,10 @@ export const CDNIcon: React.FC<CDNIconProps> = ({
         xhr.open('GET', `${baseUrl}/${name}.svg`);
         xhr.send();
         xhr.onload = function onload() {
+            setLoadingStatus(LoadingStatus.SUCCESS);
             const svg = xhr.response;
 
             if (svg.startsWith('<svg')) {
-                setLoadingStatus(LoadingStatus.SUCCESS);
                 setIcon(svg);
             }
         };
@@ -75,7 +75,9 @@ export const CDNIcon: React.FC<CDNIconProps> = ({
     return (
         <span
             style={{ color }}
-            className={cn(styles.component, className, { [styles.parentColor]: monoIcon })}
+            className={cn('cc-cdn-icon', styles.component, className, {
+                [styles.parentColor]: monoIcon,
+            })}
             data-test-id={dataTestId}
             {...(loadingStatus === LoadingStatus.FAILURE
                 ? { children: fallback }

diff --git a/packages/icon-view/src/components/base-shape/index.module.css b/packages/icon-view/src/components/base-shape/index.module.css
@@ -53,7 +53,8 @@
     left: 50%;
     transform: translate(-50%, -50%);
 
-    & svg {
+    & svg,
+    :global(.cc-cdn-icon) {
         width: 100%;
         height: 100%;
     }