Merge pull request #226 from expcapitaldev/1.0.1-dev-1.0

fix(ios): show alert in background thread with native crash
cordova-sms · Jan 12, 2022 · d4e5ca8 · d4e5ca8
2 parents bcc7ac4 + a579f8f
commit d4e5ca8
Showing 1 changed file with 19 additions and 14 deletions.
diff --git a/src/ios/Sms.m b/src/ios/Sms.m
@@ -8,22 +8,27 @@ - (void)send:(CDVInvokedUrlCommand*)command {
         self.callbackID = command.callbackId;
 
         if(![MFMessageComposeViewController canSendText]) {
-            NSString *errorMessage = @"SMS Text not available.";
-            UIAlertView *alert = [[UIAlertView alloc] initWithTitle:@"Notice"
-                                                            message:errorMessage
-                                                           delegate:self
-                                                  cancelButtonTitle:@"OK"
-                                                  otherButtonTitles:nil
-                                  ];
 
-            dispatch_async(dispatch_get_main_queue(), ^{
-                [alert show];
-                CDVPluginResult* pluginResult = [CDVPluginResult resultWithStatus:CDVCommandStatus_ERROR
-                                                                  messageAsString:errorMessage];
+        	dispatch_async(dispatch_get_main_queue(), ^{
+				NSString *errorMessage = NSLocalizedString(@"SMS Text not available.", nil);
 
-                [self.commandDelegate sendPluginResult:pluginResult callbackId:self.callbackID];
-            });
-            return;
+				UIAlertController * alert = [UIAlertController
+											 alertControllerWithTitle:[[NSBundle mainBundle] objectForInfoDictionaryKey:@"CFBundleDisplayName"]
+											 message:errorMessage
+											 preferredStyle:UIAlertControllerStyleAlert];
+
+				UIAlertAction *ok =[
+									UIAlertAction actionWithTitle:NSLocalizedString(@"OK", nil)
+									style:UIAlertActionStyleDefault
+									handler:^(UIAlertAction *action){
+										CDVPluginResult* pluginResult = [CDVPluginResult resultWithStatus:CDVCommandStatus_ERROR messageAsString:errorMessage];
+										[self.commandDelegate sendPluginResult:pluginResult callbackId:self.callbackID];
+										}
+									];
+				[alert addAction:ok];
+				[self.viewController presentViewController:alert animated:YES completion:nil];
+			});
+			return;
         }
 
         dispatch_async(dispatch_get_main_queue(), ^{