fix(ios): show alert in background thread

cordova-sms · Dec 3, 2021 · bf68a9e · bf68a9e
1 parent bcc7ac4
commit bf68a9e
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 16 deletions.
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "cordova-sms-plugin",
-  "version": "1.0.1",
+  "version": "1.0.1-dev-1.0",
   "description": "Cross-platform plugin for Cordova / PhoneGap to to easily send SMS. Available for Android, iOS and WP.",
   "cordova": {
     "id": "cordova-sms-plugin",

diff --git a/plugin.xml b/plugin.xml
@@ -2,7 +2,7 @@
 <plugin xmlns="http://www.phonegap.com/ns/plugins/1.0"
         xmlns:android="http://schemas.android.com/apk/res/android"
            id="cordova-sms-plugin"
-      version="1.0.1">
+      version="1.0.1-dev-1.0">
     <name>Cordova SMS Plugin</name>
     <description>Cross-platform plugin for Cordova / PhoneGap to to easily send SMS. Available for Android and iOS.</description>
     <license>MIT</license>

diff --git a/src/ios/Sms.m b/src/ios/Sms.m
@@ -8,22 +8,27 @@ - (void)send:(CDVInvokedUrlCommand*)command {
         self.callbackID = command.callbackId;
 
         if(![MFMessageComposeViewController canSendText]) {
-            NSString *errorMessage = @"SMS Text not available.";
-            UIAlertView *alert = [[UIAlertView alloc] initWithTitle:@"Notice"
-                                                            message:errorMessage
-                                                           delegate:self
-                                                  cancelButtonTitle:@"OK"
-                                                  otherButtonTitles:nil
-                                  ];
 
-            dispatch_async(dispatch_get_main_queue(), ^{
-                [alert show];
-                CDVPluginResult* pluginResult = [CDVPluginResult resultWithStatus:CDVCommandStatus_ERROR
-                                                                  messageAsString:errorMessage];
+        	dispatch_async(dispatch_get_main_queue(), ^{
+				NSString *errorMessage = NSLocalizedString(@"SMS Text not available.", nil);
 
-                [self.commandDelegate sendPluginResult:pluginResult callbackId:self.callbackID];
-            });
-            return;
+				UIAlertController * alert = [UIAlertController
+											 alertControllerWithTitle:[[NSBundle mainBundle] objectForInfoDictionaryKey:@"CFBundleDisplayName"]
+											 message:errorMessage
+											 preferredStyle:UIAlertControllerStyleAlert];
+
+				UIAlertAction *ok =[
+									UIAlertAction actionWithTitle:NSLocalizedString(@"OK", nil)
+									style:UIAlertActionStyleDefault
+									handler:^(UIAlertAction *action){
+										CDVPluginResult* pluginResult = [CDVPluginResult resultWithStatus:CDVCommandStatus_ERROR messageAsString:errorMessage];
+										[self.commandDelegate sendPluginResult:pluginResult callbackId:self.callbackID];
+										}
+									];
+				[alert addAction:ok];
+				[self.viewController presentViewController:alert animated:YES completion:nil];
+			});
+			return;
         }
 
         dispatch_async(dispatch_get_main_queue(), ^{