Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CORL-1464] Improve Subscription Memory Usage #3241

Merged
merged 2 commits into from
Oct 28, 2020

Conversation

wyattjoh
Copy link
Collaborator

@wyattjoh wyattjoh commented Oct 22, 2020

What does this PR do?

Thanks to the suggestion from @brettjashford over at apollographql/graphql-subscriptions#209 (comment) this provides an alternative implementation of the withFilter that uses native async iterators. This bypasses the issue with the workarounds existing in the graphql-subscriptions package for older versions of NodeJS.

What changes to the GraphQL/Database Schema does this PR introduce?

None.

How do I test this PR?

Try to perform some actions that would trigger traffic to go across the subscription system.

@wyattjoh wyattjoh added this to the v6.4.0 milestone Oct 22, 2020
@wyattjoh wyattjoh requested a review from cvle October 22, 2020 16:40
@wyattjoh wyattjoh force-pushed the fix/subscription-memory-fix branch from f08e9b4 to 131c739 Compare October 23, 2020 22:25
@wyattjoh wyattjoh added the 🚀 merge it! Pull requests that should be merged after status checks pass with a review label Oct 28, 2020
@kodiakhq kodiakhq bot merged commit 45868ae into master Oct 28, 2020
@kodiakhq kodiakhq bot deleted the fix/subscription-memory-fix branch October 28, 2020 17:06
wyattjoh added a commit that referenced this pull request Oct 30, 2020
* fix: revert custom async iterator to resolve memory

* chore: bump 6.4.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚀 merge it! Pull requests that should be merged after status checks pass with a review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants