New experiments features (model/agent/representation comparison, ...) #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…esearch/SeaPearlZoo into louis/experiments_fixes
gostreap
requested changes
Aug 17, 2022
learning_cp/nqueens/rewards.jl
Outdated
| @@ -50,5 +50,28 @@ end | |||
|
|
|||
| function SeaPearl.set_reward!(::Type{SeaPearl.EndingPhase}, lh::SeaPearl.LearnedHeuristic{SR,NQueenReward,O}, model::SeaPearl.CPModel, symbol::Union{Nothing,Symbol}) where {SR <: SeaPearl.AbstractStateRepresentation,O <: SeaPearl.ActionOutput} | |||
| lh.current_reward += 100 / model.statistics.numberOfNodes | |||
| # Getting the number of conflicts on nqueens(20) | |||
There was a problem hiding this comment.
It seems to me that the work related to NQueenReward has been abandoned, not giving good results. The good ideas have been incorporated in the GeneralReward.
| @@ -128,16 +127,16 @@ function trytrain(nbEpisodes::Int) | |||
| experienceTime = now() | |||
| dir = mkdir(string("exp_",Base.replace("$(round(experienceTime, Dates.Second(3)))",":"=>"-"))) | |||
| expParameters = Dict( | |||
There was a problem hiding this comment.
The use of ExpParameters has been dropped.
gostreap
approved these changes
Aug 17, 2022
…o into heterogeneous
…o into heterogeneous
|
What's the status of this PR? Anything interesting we can merge? |
|
The PR can be merge, it contains many new features for the different experiments we run for the paper. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.