WIP Vine Shared Filesystem Mode #3944
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dthain
force-pushed
the
vine-shared-fs-mode
branch
from
08adc72 to
1f2999c
Compare
…x to shared filesystem. - Added shared_filesystem_link_mode to replace VINE_FILE with VINE_SHAREDFS. - Rename load_from_shared_fs to shared_filesystem_cache_mode, which replaces VINE_FILE with VINE_URL.
dthain
force-pushed
the
vine-shared-fs-mode
branch
from
1f2999c to
cc66f42
Compare
|
Ah, this is not going work to a variety of reasons, retrying again with a simpler approach. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Added new access mode enabled by vine_tune() to compare TaskVine caching behavior to direct use of shared filesystem.
Merge Checklist
The following items must be completed before PRs can be merge.
Check these off to verify you have completed all steps.
make testRun local tests prior to pushing.make formatFormat source code to comply with lint policies. Note that some lint errors can only be resolved manually (e.g., Python)make lintRun lint on source code prior to pushing.