-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds a production ready docker environment #730
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @microstudi! Seems fine to me ✅, at least as far as I know Docker 😅
@microstudi I added some small comments 🙏🏼 and I see there is also 1 failing test: https://github.com/coopdevs/timeoverflow/actions/runs/7800180296/job/21272472836?pr=730#step:5:25. The rest seems good to me 👌🏼. |
@markets the failing test is due the update of the imagemagik library. I've fixed it but something happened with the upload coverage. |
This PR optimizes the application for its use in Docker images:
Testing
Run
Visit http:/localhost:3000/
Env vars summary:
RAILS_ENV
production
SECRET_KEY_BASE
rails secret
DATABASE_URL
postgresql://user:password@host:port/database
RAILS_SERVE_STATIC_FILES
public
folder)true
RAILS_LOG_TO_STDOUT
true
RAILS_LOG_LEVEL
debug
for maximum information)info
RAILS_MAX_THREADS
1
if multithreading is not desired)5
RAILS_MIN_THREADS
RAILS_MAX_THREADS
valueWEB_CONCURRENCY
2
RUN_SIDEKIQ
true
RUN_RAILS
true
QUEUE_ADAPTER
sidekiq
SIDEKIQ_CONCURRENCY
5
STORAGE_PROVIDER
local
andamazon
)local
FORCE_SSL
false
MAIL_LINK_HOST
mydomain.tld
)MAIL_LINK_PROTOCOL
https
SMTP_ADDRESS
smtp.mailgun.org
)SMTP_PORT
587
)SMTP_DOMAIN
SMTP_USER_NAME
SMTP_PASSWORD
SMTP_AUTHENTICATION
plain
SMTP_ENABLE_STARTTLS_AUTO
true
SMTP_OPENSSL_VERIFY_MODE
none
AWS_ACCESS_KEY_ID
STORAGE_PROVIDER
isamazon
)AWS_SECRET_ACCESS_KEY
STORAGE_PROVIDER
isamazon
)AWS_BUCKET
STORAGE_PROVIDER
isamazon
)AWS_REGION
STORAGE_PROVIDER
isamazon
)ADMINS
[email protected]