Add integration test for installing pysnooper #76
Conversation
|
Cool, can you please add a line that at least imports pysnooper to ensure that it's installed? |
Yes, I will do that with |
|
You need a line with |
|
I don't know why but the logs don't show the desired commands being run: https://travis-ci.org/cool-RR/PySnooper/jobs/526204104 |
| [pysnooper] | ||
| commands = | ||
| pip install pysnooper | ||
| pip show pysnooper |
There was a problem hiding this comment.
This is unneeded. You can remove it. (Explanation: The [<tool_name>] sections are configuration file sections that the tool reads. I don't think pysnooper reads anything out from tox.ini.)
| @@ -54,6 +56,13 @@ deps = pip-tools | |||
| commands = pip-compile --output-file requirements.txt requirements.in | |||
| changedir = {toxinidir} | |||
|
|
|||
| [testenv:pysnooper] | |||
| description = Ensure pip installs pysnooper | |||
| deps = pip | |||
There was a problem hiding this comment.
No need to install pip. Replace this by pysnooper if you want to install it off PyPI (that's probably not what you want), or leave it empty.
| deps = pip | ||
| commands = | ||
| pip install pysnooper | ||
| pip show pysnooper |
There was a problem hiding this comment.
This is not an integration test.
Think: What does this verify? Is the pysnooper code run with it? (It's not.)
Also, installing pysnooper is unneeded, and even if it were you can move it to deps = .
| @@ -16,6 +17,7 @@ description = Unit tests | |||
| deps = | |||
| pytest | |||
| python_toolbox | |||
| pysnooper | |||
There was a problem hiding this comment.
This installs the latest released version of pysnooper off PyPI. This is most probably not what you want.
Note that pysnooper (off the checked out commit) is already installed by Tox automatically. Try running pysnooper or python -c "import pysnooper; print(pysnooper.__version__)" to prove it.
| - { stage: test, python: 2.7, env: TOKENV=pysnooper } | ||
| - { stage: test, python: 3.8-dev, env: TOKENV=pysnooper } | ||
| - { stage: test, python: pypy2.7-6.0, env: TOKENV=pysnooper } | ||
| - { stage: test, python: pypy3.5, env: TOKENV=pysnooper } |
There was a problem hiding this comment.
This looks very verbose.
What if you simply would run your integration test with the [testenv] section? (Then all this would not be needed. Hmm?)
|
I think, this contribution can be much simpler: Simply add an additional command that performs the desired integration test to the commands =
pytest
python -c "print('run my integration test')"I'd also suggest to add [pytest]
addopts = --strict --verboseThis makes the output easier to understand. I see you removed it, Ram, due to problems with the IDE, hmm. |
|
Please note, everyone, that pysnooper is always installed by Tox automatically. That's the whole purpose of a Tox setup: It installs the package under test (using Take a look at older builds to prove yourself. Note the zip (created by setuptools) and the installed pysnooper version (even though it's not specified anyhere explicitly for installation). |
|
Thanks for your input @bittner. I'll make these changes as soon as I can. |
|
Actually, I'm just going to close out this PR. |
#39: Add tox environment for installing pysnooper.