Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-add ability to convert OSM URLs into geo-uris #3161

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ChaosKid42
Copy link
Contributor

I'd like to re-add the possibility to let converse.js convert OSM-URLs to geo-uris. It is now turned off by default though.

@ChaosKid42 ChaosKid42 requested a review from jcbrand April 11, 2023 12:03
@ChaosKid42 ChaosKid42 force-pushed the convert_urls_to_geo_uris branch 2 times, most recently from 316e983 to f190518 Compare June 9, 2023 10:42
@jcbrand
Copy link
Member

jcbrand commented Jun 9, 2023

Hi @ChaosKid42, could you tell me what the benefit of this feature is and what exactly you're using it for?

Also, if we merge this PR, then this ticket is again relevant, right?
#2914

@ChaosKid42
Copy link
Contributor Author

Hi @ChaosKid42, could you tell me what the benefit of this feature is and what exactly you're using it for?

Also, if we merge this PR, then this ticket is again relevant, right? #2914

Hi @jcbrand, the idea is to use openstreetmap (or a similar corporate version of it) to select a geolocation an send it to a smartphone which uses Conversations (by simply copying the URL into the message box). By converting it to a geo-uri, Conversations will render it as a position and the user will be able to very easily e.g. open a navigation app for routing to the given location.

And yes #2914 is still relevant from my point of view. If you like, I can work on the PR to incorporate the original URL in the changed message. I would of course also update the tests accordingly.

@jcbrand
Copy link
Member

jcbrand commented Jun 9, 2023

Hi @jcbrand, the idea is to use openstreetmap (or a similar corporate version of it) to select a geolocation an send it to a smartphone which uses Conversations (by simply copying the URL into the message box). By converting it to a geo-uri, Conversations will render it as a position and the user will be able to very easily e.g. open a navigation app for routing to the given location.

It would be nice if the geolocation data could be sent as metadata (e.g. via XEP-0066) instead of modifying the actual chat message. Perhaps Conversations might already support that @iNPUTmice?

And yes #2914 is still relevant from my point of view. If you like, I can work on the PR to incorporate the original URL in the changed message. I would of course also update the tests accordingly.

Yes, that would be greatly appreciated!

@jcbrand
Copy link
Member

jcbrand commented Jun 9, 2023

@ChaosKid42 Not a blocker, but would be nice if you could cherry-pick the original commits from #2914 onto your branch (you might have to fix conflicts) so that the author of that PR gets credited for his work.

You can then make a follow-up commit to clean things up and/or improve things as you see fit for the final product.

@jcbrand
Copy link
Member

jcbrand commented Jun 9, 2023

This might also still be relevant: #1850

@ChaosKid42 ChaosKid42 force-pushed the convert_urls_to_geo_uris branch 5 times, most recently from 06c9f4c to 0f571df Compare June 10, 2023 07:16
@jcbrand
Copy link
Member

jcbrand commented Jun 23, 2023

@ChaosKid42 Are you still busy with this PR? The tests are still failing.

@ChaosKid42
Copy link
Contributor Author

@ChaosKid42 Are you still busy with this PR? The tests are still failing.

@jcbrand I started working on this but didin't find the time to really finish it. I'll let you know if I make progress ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants