Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update code owners, all code additional assigned to @jondkent @abdull… #313

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

update code owners, all code additional assigned to @jondkent @abdull… #313

wants to merge 5 commits into from

Conversation

jondkent
Copy link
Contributor

@jondkent jondkent commented Mar 4, 2021

update code owners, all code additional assigned to @jondkent @abdullahgarcia where missing

@jondkent jondkent requested a review from a team as a code owner March 4, 2021 11:44
@jondkent jondkent requested review from abdullahgarcia and removed request for a team March 4, 2021 11:45
sublimino
sublimino approved these changes Mar 4, 2021
View reviewed changes
Copy link
Member

@sublimino sublimino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM : ]

@sublimino sublimino removed the request for review from abdullahgarcia March 4, 2021 16:55
@sublimino
Copy link
Member

You'll need to sign the commit to get this past branch protection @jondkent

@jondkent
Copy link
Contributor Author

jondkent commented Mar 5, 2021

You'll need to sign the commit to get this past branch protection @jondkent

Forgot about that. I'll sort that out

@abdullahgarcia abdullahgarcia self-requested a review March 5, 2021 10:34
abdullahgarcia
abdullahgarcia approved these changes Mar 5, 2021
View reviewed changes
Copy link
Contributor

@abdullahgarcia abdullahgarcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@abdullahgarcia
Copy link
Contributor

@sublimino , wanna close this pull request? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abdullahgarcia abdullahgarcia abdullahgarcia approved these changes

@sublimino sublimino sublimino approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jondkent @sublimino @abdullahgarcia