[v4] FIX compile error #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PHP 8.2 Declaration of Contributte\FormMultiplier\Multiplier::setValues($values, bool $erase = false): Contributte\FormMultiplier\Multiplier must be compatible with Nette\Forms\Container::setValues(object|array $data, bool $erase = false): static (cherry picked from commit 9b4e600)
`Container::getComponents()` returns array when `$deep` is false (by default): nette/component-model@7f613ee The method also no longer takes any arguments: nette/component-model@4e0946a (cherry picked from commit ccf29ba)
jtojnar
force-pushed
the
backport-php83-fix
branch
from
5337806 to
f3a0afb
Compare
|
Not sure why the code coverage segfaults but tests pass now. |
Closed
jtojnar
force-pushed
the
backport-php83-fix
branch
from
f3a0afb to
e88d1f4
Compare
Partly reverts the parent commit.
This fixes the following PHPStan errors: 280 Method Contributte\FormMultiplier\Multiplier::getValues() has parameter $returnType with no type specified. 290 No error to ignore is reported on line 290. (cherry picked from commit 42e1ced) We are not cherry-picking the nette/forms bump. Fix coding style (cherry picked from commit f7ebe4d)
nette/component-model 3.1.0 made the type annotations more precise, correctly declaring that `null` will not be returned when `$throw` argument is `true` (default): nette/component-model@fbab7bc As a result PHPStan started to complain: Expression on left side of ?? is not nullable. (cherry picked from commit 7445d0d, 2afcd08)
jtojnar
force-pushed
the
backport-php83-fix
branch
from
e88d1f4 to
15527e5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHP 8.2
Declaration of Contributte\FormMultiplier\Multiplier::setValues($values, bool $erase = false): Contributte\FormMultiplier\Multiplier must be compatible with Nette\Forms\Container::setValues(object|array $data, bool $erase = false): static
(cherry picked from commit 9b4e600)