chore(deps): migrate from enzyme to @testing-library/react #635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denkristoffer
force-pushed
the
react-testing-library
branch
from
c4b6d98 to
7971a4a
Compare
|
Deploy preview for forma-36-react-components ready! Built with commit 003c8ce https://deploy-preview-635--forma-36-react-components.netlify.app |
denkristoffer
force-pushed
the
react-testing-library
branch
3 times, most recently
from
022c137 to
6e011f3
Compare
`gridColumnGap` -> `columnGap` `gridRowGap` -> `rowGap` Why did it work before? Not sure.
denkristoffer
force-pushed
the
react-testing-library
branch
from
6e011f3 to
5a4b988
Compare
denkristoffer
requested review from
burakukula,
gui-santos,
m10l and
mshaaban0
as code owners
mshaaban0
approved these changes
Nov 12, 2020
m10l
approved these changes
Nov 12, 2020
|
@m10l I'm for it, but I don't really have an idea of how much |
gui-santos
approved these changes
Nov 12, 2020
There was a problem hiding this comment.
GREAT!
I vote for removing the enzyme test as @m10l suggested
denkristoffer
force-pushed
the
react-testing-library
branch
from
bf3d539 to
9df4ffc
Compare
|
I've deleted the test and removed enzyme completely 👍 |
The test requires enzyme and isn't easy to refactor to testing-library
denkristoffer
force-pushed
the
react-testing-library
branch
from
7dec859 to
003c8ce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of PR
Migrate from
enzymeto@testing-library/react. This is to align testing libraries used across components, to more quickly allow for major React upgrades, and to unblock #611.There's still a single component on enzyme,
InViewport.test.tsx:These tests use enzyme's
instance()which testing-library doesn't support:I'm not sure how to test it without rewriting the component completely, which defeats the purpose.
PR Checklist
readme.mdfile(s)