Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update example-config.json #1282

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update example-config.json #1282

wants to merge 1 commit into from

Conversation

mdole
Copy link

@mdole mdole commented Feb 11, 2023

The CLI no longer supports skipEditorInterfaces, limit and now supports header, timeout, retryLimit, skipTags, stripTags. Update to make the example config more accurate!

The CLI no longer supports `skipEditorInterfaces, limit` and now supports `header, timeout, retryLimit, skipTags, stripTags`
@mdole mdole requested a review from a team as a code owner February 11, 2023 11:14
Copy link
Contributor

@ruderngespra ruderngespra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, hey, thanks for contributing!

This example config is meant to show all options which are available for using contentful-export as standalone tool or CLI.

With that in mind, I don't think it makes sense to adjust as you are suggesting.

I think skipEditorInterfaces and limit still will be picked up from contentful-export, see e.g. https://github.com/contentful/contentful-export/blob/master/lib/index.js#L79.

As for the new additions, I don't think all of them are supported in contentful-export directly, e.g. retryLimit is something only implemented in https://github.com/contentful/contentful-cli.

I would suggest keeping this example config to what the export tool as such supports. Let me know what you think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants