chore: remove vulnerable dependencies from Ecommerce app #9103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ecommerce-app-base-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
mgoudy91
approved these changes
Oct 16, 2024
There was a problem hiding this comment.
I'll preface this by saying this looks great to me and I'm not explicitly worried about anything specific. 👍
I'd just ask that we are ready to group-test every app that uses the ecomm base when we merge this, since the blast radius is pretty big.
Even before that I would probably do a local symlink of the ecommerce app base in a few apps (commercetools, shopify, etc) and make sure everything looks good.
Hate to be onerous but I think the potential impact of changes to the app base warrant it.
Nice work!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
INTEG-2197
Approach
Testing steps
Breaking Changes
Dependencies and/or References
Deployment