Fixes 3877: Add required fields for API spec requests

[Andrewgdewar]

Summary

• Add required fields for API spec requests.

Testing steps

[jlsherrill]

https://issues.redhat.com/browse/HMS-3877

[swadeley]

Hi

How to test these changes?

If I take the first one:

   "definitions": {
        "api.AddUploadsRequest": {
            "type": "object",
            "required": [
                "artifacts",
                "uploads"
            ],

Looking at "add_upload" in ephemeral I do not see anything different to that in stage:

app.content_sources.rest_client.repositories_api.add_upload.
                                                                      allowed_values  call_with_http_info() headers_map           params_map           
                                                                      api_client            callable()            location_map          settings             
                                                                      attribute_map         collection_format_map openapi_types         validations        

[jlsherrill]

I don't know that the changes need to be tested, but if you regenerate the api bindings you will see that code will likely need to be changed. for example, this method signature changes:

@@ -102,9 +102,12 @@ class ApiContentUnitSearchRequest(ModelNormal):
     ])

     @convert_js_args_to_python_args
-    def __init__(self, *args, **kwargs):  # noqa: E501
+    def __init__(self, search, *args, **kwargs):  # noqa: E501
         """ApiContentUnitSearchRequest - a model defined in OpenAPI

+        Args:
+            search (str): Search string to search content unit names
+

So if you are using the generated bindings its clearer that 'search' is required to be specified. This doesn't actually change the behavior of the API at all (hence why the tests all pass without generating the bindings)

[Andrewgdewar]

Thanks for the review @rverdile @xbhouse!

[rverdile]

there's some tests failing :)

you might have to rebase as well

[rverdile]

I thought I saw them before, but TemplateRequest and RepositoryRequest are missing

[Andrewgdewar]

I thought I saw them before, but TemplateRequest and RepositoryRequest are missing

Thanks for the feedback here, I did add to the template and repository request. Please confirm if those changes make sense.

[rverdile]

that's my last comment :)

[Andrewgdewar]

@rverdile @xbhouse Thank you for your thorough review here, I'm still learning 🍼 👶, I appreciate your patience!!

[rverdile]

lgtm!

[swadeley]

/retest

[swadeley]

Hi

I found that I had to add origin="external to all repo create calls.
No changes to anything related to search this time (search calls had origin="external from a while back)

[rverdile]

Ah, it seems origin is actually not a required field. We should remove that then.