feat: Handle termination signals #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch adds handling of SIGINT and SIGTERM so that the server is closed gracefully. It also moves the code that starts the server into a function (in `server.ts`), separate from the command-line entrypoint (in newly-added `main.ts`). This way, each code part's responsibilities are clearer than if the process exit logic was conflated with running Fastify.
|
As an aside, due to the refactor that splits main.ts and server.ts, it will be easier to follow up with integration tests :) |
lusu007
approved these changes
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds handling of SIGINT and SIGTERM so that the server is closed gracefully. It also moves the code that starts the server into a function (in
server.ts), separate from the command-line entrypoint (in newly-addedmain.ts). This way, each code part's responsibilities are clearer than if the process exit logic was conflated with running Fastify.Additional Context
N/A
Checklist
feat: Add social login