fix: Ensure proper OIDC redirect_uri is used #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openid-client manipulates the redirect URI we gave based on the request URL, which will be wrong when behind a reverse proxy. This is a workaround for that based on upstream discussions. Alternatively, it may be possible to configure the trust proxy setting, but this is a burden on users and not really necessary when we already have the URL and could use it as-is.
lusu007
approved these changes
Dec 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
openid-client manipulates the redirect URI we gave based on the request URL, which will be wrong when behind a reverse proxy. This is a workaround for that based on upstream discussions.
Additional Context
Alternatively, it may be possible to configure the trust proxy setting, but this is a burden on users and not really necessary when we already have the URL and could use it as-is.
Checklist
feat: Add social login