feat: Optimize Docker image, build for amd64+arm64 #173
+51
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The image size is reduced by 13% using the following measures:
* Extended .dockerignore to remove further metadata and tests.
This also ensures better layer caching for repeat builds.
* Cleaning npm cache for the final stage.
Inline source maps are enabled to improve error reporting. Stack traces will
now refer to the TypeScript source locations instead of transpiled JS.
Multiplatform build for arm64 in addition to amd64 is enabled to improve
performance on ARM devices due to not needing emulation.
Finally, the `docker run` example in README.md is amended to include
security best practices.
lusu007
previously approved these changes
Dec 1, 2024
|
The PR build is unfortunately much slower now (around 8 minutes). This could be resolved by hosting the multistage build on an Arm64 runner (due to efficient x86_64 emulation, vs. the other way around), but these are not yet available for the GitHub free tier, unfortunately. |
lusu007
approved these changes
Dec 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The image size is reduced by 13% using the following measures:
Inline source maps are enabled to improve error reporting. Stack traces will now refer to the TypeScript source locations instead of transpiled JS.
Multiplatform build for arm64 in addition to amd64 is enabled to improve performance on ARM devices due to not needing emulation.
Finally, the
docker runexample in README.md is amended to include security best practices.Additional Context
N/A
Checklist
feat: Add social login