cmd/run: Use home folder when $PWD is not in toolbox #565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HarryMichal
added
3. Enhancement
|
Build failed.
|
HarryMichal
force-pushed
the
gracefully-handle-missing-paths
branch
from
ef8299d to
25c81f3
Compare
|
recheck |
Since v0.0.91[0] Toolbox throws an error if $PWD is not available in a toolbox. While this fixes the problem with 'toolbox enter/run' silently failing to enter/exec in a container, it still requires an action to be made by the user. I believe it is better to handle such situations more gracefully by falling back to entering the user's home folder + printing a warning about doing so. [0] containers#370
HarryMichal
force-pushed
the
gracefully-handle-missing-paths
branch
from
25c81f3 to
18a38b9
Compare
HarryMichal
added
the
2. Container Realm
debarshiray
reviewed
Jun 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since v0.0.91[0] Toolbox throws an error if $PWD is not available in a
toolbox. While this fixes the problem with 'toolbox enter/run' silently
failing to enter/exec in a container, it still requires an action to be
made by the user. I believe it is better to handle such situations more
gracefully by falling back to entering the user's home folder + printing
a warning about doing so.
[0] #370