Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add support for vllm container image #351

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rhatdan
Copy link
Member

@rhatdan rhatdan commented Oct 21, 2024

No description provided.

@rhatdan
Copy link
Member Author

rhatdan commented Oct 21, 2024

@ericcurtin First attempt to get vllm based container for running ramalama. Sadly blows up after pulling Model. Not sure what is going wrong.

@ericcurtin
Copy link
Collaborator

Maybe we should reach out to IBM and ask them to rebase their fork against upstream:

https://github.com/IBM/vllm

.gguf support only made vllm very recently. Could try using upstream also to see if it makes a difference.

It would also be interesting to query some IBM folk as to why they fork.

@dtrifiro
Copy link

dtrifiro commented Nov 13, 2024

IBM is currently using the version here: https://github.com/opendatahub-io/vllm, the main Dockerfile is Dockerfile.ubi.

This is built and pushed to quay.io/repository/opendatahub/vllm (fast tag)

@danielezonca
Copy link

@dtrifiro
Can you help with this PR?
The goal is to add vLLM (mainly CPU+cuda I would say, we can iterate and other accelerator later) to ramalama.
I don't think it should require special customization but maybe there are options that can help

@ericcurtin
That IBM fork is old and not used anymore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants