feat: adding execute method to PodmanConnection class #1813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: axel7083 <[email protected]>
axel7083
requested review from
benoitf,
jeffmaury and
a team
as code owners
1 task
benoitf
reviewed
Sep 30, 2024
| return this.execute(connection, ['machine', 'ssh', this.getNameLegacyCompatibility(connection), ...args], options); | ||
| } | ||
|
|
||
| /** |
There was a problem hiding this comment.
I'm not sure we need the code for < 1.13 as the extension is already requiring API > 1.13.0
There was a problem hiding this comment.
We are not ?
We uses the latest api, but we don't have hard requirements on latest version, so we are in theory compatible with older version up to 1.8.
There was a problem hiding this comment.
in the catalog it says minimum 1.12 for 1.2 of ai lab
https://github.com/containers/podman-desktop-catalog/blob/gh-pages/api/extensions.json#L689
and in package.json, we consume 1.13.0 snapshot API
I'm assuming some API changes (new additions) are also missing since 1.8
so consuming 1.13 API should result in 1.13 minimal requirement
benoitf
approved these changes
Oct 1, 2024
gastoner
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds
executeandexecuteSSHmethod to thePodmanConnectionclass in AI Lab. The purpose is to centralize the code using the podman cli (E.g. model management, WSL Upload)The new added code takes advantages of podman-desktop/podman-desktop#8891, but still support through
Legacyfunction previous version of podman-desktop (<1.13).I split the feature in two
Screenshot / video of UI
N/A
What issues does this PR fix or reference?
Required for #1810
How to test this PR?